This patch corrects the definition of the DINSM instruction. Specification for DINSM instruction for Mips64 says that size operand should be 2 <= size <= 64, but it is defined as uimm5_inssize_plus1 which gives range of 1 .. 32.
Can you add a test case along the lines of:
dinsm $4, $5, 31, 33
I've noticed that the dext and dins family of instructions are not tested in those files.
LGTM with inline nit addressed.
|109 ↗||(On Diff #114797)|
This should be 34, as 32 is a valid operand for uimm5_inssize_plus1. 34 is not valid for uimm5_inssize_plus1 but is valid by the ISA description of the instruction.
|117 ↗||(On Diff #114797)|
See my previous comment.