This allows the flag to be persisted through to LTO.
Details
Diff Detail
- Repository
- rL LLVM
Event Timeline
Reckon maybe a test case with two units - one using gnu pubnames, one not, would be worth having to demonstrate that all works fine & is appropriately respected?
llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp | ||
---|---|---|
412–422 ↗ | (On Diff #114466) | Looks like this function could be moved to be a member of DwarfCompileUnit? (& move the DwarfPubSections opt into the DwarfCompileUnit.cpp file?) Just a thought - see how you feel about it, if you think it's better here, that's fine. |
llvm/test/DebugInfo/X86/gnu-public-names-gmlt.ll | ||
1 ↗ | (On Diff #114466) | Is this use of 'sed' in a RUN line portable to windows (I forget exactly which command line tools are available/dependendable in the lit environment there)? |
Added, see llvm/test/DebugInfo/X86/gnu-public-names-multiple-cus.ll.
llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp | ||
---|---|---|
412–422 ↗ | (On Diff #114466) | I think that makes sense, done. What do you think about removing the -generate-dwarf-pub-sections flag entirely? It seems that we only use it in a handful of tests where it looks like it would suffice to use -debugger-tune instead. In any event, that can probably be done as a followup. |
llvm/test/DebugInfo/X86/gnu-public-names-gmlt.ll | ||
1 ↗ | (On Diff #114466) | I think so, we are using sed like this in a few places already: http://llvm-cs.pcc.me.uk/?q=RUN%3A+sed |
Looks totally reasonable to me. Going through and cleaning up the last set of bool flags when you get a chance would be nice.