This is an archive of the discontinued LLVM Phabricator instance.

Shorten filenames of tests (-with-calls to -wcalls)
ClosedPublic

Authored by krytarowski on Aug 25 2017, 8:32 AM.

Details

Summary

The NetBSD's 8(beta) versions of kernel functions to retrieve
program name (vnode to path translator) and process memory
map has internal limit of processing file names with maximum
of 31 characters.

Filenames like Asan-x86_64-with-calls-Noinst-Test break this
limit and affect tests. Rename "-with-calls" to "-wcalls".

This changes fixes all issues for the Address Sanitizer test
target (check-asan) on the current NetBSD support caused
by long filenames.

Sponsored by <The NetBSD Foundation>

Diff Detail

Repository
rL LLVM

Event Timeline

krytarowski created this revision.Aug 25 2017, 8:32 AM

Any comments on it?

vitalybuka accepted this revision.Aug 28 2017, 3:52 PM
vitalybuka added inline comments.
lib/asan/tests/CMakeLists.txt
270

just "-calls" ?

This revision is now accepted and ready to land.Aug 28 2017, 3:52 PM

I will commit it as calls, thanks!

krytarowski closed this revision.Aug 28 2017, 6:04 PM

I've committed it as r. 311966 with "calls" and removed comment.