This is an archive of the discontinued LLVM Phabricator instance.

[mips] Free up two values in SubtargetFeatureFlag by folding the redundant IsGP32/IsGP64 into IsGP32bit/IsGP64bit
ClosedPublic

Authored by dsanders on May 9 2014, 8:44 AM.

Details

Summary

We are currently very close to the 32-bit limit of the current assembler
implementation. This is because there is no way to represent an instruction
that is available in, for example, Mips3 or Mips32. We have to define a
feature bit that represents this.

This patch cleans up a pair of redundant feature bits and slightly postpones the
point we will reach the limit.

Diff Detail

Event Timeline

dsanders updated this revision to Diff 9263.May 9 2014, 8:44 AM
dsanders retitled this revision from to [mips] Free up two values in SubtargetFeatureFlag by folding the redundant IsGP32/IsGP64 into IsGP32bit/IsGP64bit.
dsanders updated this object.
dsanders edited the test plan for this revision. (Show Details)
vmedic accepted this revision.May 13 2014, 3:10 AM
vmedic edited edge metadata.

LGTM

This revision is now accepted and ready to land.May 13 2014, 3:10 AM
dsanders closed this revision.May 13 2014, 4:25 AM