Page MenuHomePhabricator

[mips][mips64r6] Add sel.s and sel.d
ClosedPublic

Authored by dsanders on May 8 2014, 6:14 AM.

Diff Detail

Event Timeline

dsanders updated this revision to Diff 9211.May 8 2014, 6:14 AM
dsanders retitled this revision from to [mips][mips64r6] Add sel.s and sel.d.
dsanders updated this object.
dsanders edited the test plan for this revision. (Show Details)
jkolek accepted this revision.May 14 2014, 7:00 AM
jkolek edited edge metadata.

LGTM with a small suggestion.

lib/Target/Mips/Mips32r6InstrFormats.td
41

To reuse this class http://reviews.llvm.org/D3709 I have changed the name of this class to COP1_3R_FM and I have added funct parameter. Maybe this can be done right here, to not change already committed code later.

class COP1_3R_FM<bits<6> funct, FIELD_FMT Format> : MipsR6Inst {
63

Introduced parameter funct is used here.

let Inst{5-0} = funct;
lib/Target/Mips/Mips32r6InstrInfo.td
72
class SEL_D_ENC : COP1_3R_FM<0b010000, FIELD_FMT_D>;
class SEL_S_ENC : COP1_3R_FM<0b010000, FIELD_FMT_S>;
This revision is now accepted and ready to land.May 14 2014, 7:00 AM
jkolek added inline comments.May 14 2014, 7:14 AM
lib/Target/Mips/Mips32r6InstrFormats.td
53

I have selected a wrong line. I meant this one. Sorry.

let Inst{5-0} = funct;
63

I have selected a wrong line.

dsanders added inline comments.May 14 2014, 7:20 AM
lib/Target/Mips/Mips32r6InstrFormats.td
41

Ok, I'll make this change before commit

dsanders closed this revision.May 14 2014, 8:37 AM