Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

Differential D36925

[PPCG] Only add Kernel argument sizes for OpenCL, not CUDA runtime
ClosedPublic
Actions

Authored by PhilippSchaad on Aug 19 2017, 9:45 AM.

Details

Reviewers
bollu
grosser
Commits
rG50139f0f3844: [PPCG] Only add Kernel argument sizes for OpenCL, not CUDA runtime
rPLO311248: [PPCG] Only add Kernel argument sizes for OpenCL, not CUDA runtime
rL311248: [PPCG] Only add Kernel argument sizes for OpenCL, not CUDA runtime
Summary

Kernel argument sizes now only get appended to the kernel launch parameter list if the OpenCL runtime is selected, not if CUDA runtime is chosen.

Diff Detail

Repository
rL LLVM

Event Timeline

PhilippSchaad created this revision.Aug 19 2017, 9:45 AM
Harbormaster completed remote builds in B9442: Diff 111835.Aug 19 2017, 9:45 AM
Herald added subscribers: kbarton, Anastasia, yaxunl, nemanjai. · View Herald TranscriptAug 19 2017, 9:45 AM
grosser accepted this revision.Aug 19 2017, 9:47 AM

LGTM, very nice!

This revision is now accepted and ready to land.Aug 19 2017, 9:47 AM
Closed by commit rL311248: [PPCG] Only add Kernel argument sizes for OpenCL, not CUDA runtime (authored by phschaad). · Explain WhyAug 19 2017, 10:05 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 111837

View Options

polly/trunk/lib/CodeGen/PPCGCodeGeneration.cpp

Loading...
View Options

polly/trunk/test/GPGPU/cuda-managed-memory-simple.ll

Loading...
View Options

polly/trunk/test/GPGPU/host-control-flow.ll

Loading...
View Options

polly/trunk/test/GPGPU/invariant-load-hoisting.ll

Loading...
View Options

polly/trunk/test/GPGPU/kernel-params-only-some-arrays.ll

Loading...
View Options

polly/trunk/test/GPGPU/parametric-loop-bound.ll

Loading...
View Options

polly/trunk/test/GPGPU/phi-nodes-in-kernel.ll

Loading...