Page MenuHomePhabricator

PhilippSchaad (Philipp Schaad)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 19 2017, 12:39 AM (173 w, 1 d)

Recent Activity

Sep 19 2017

PhilippSchaad added a comment to D37429: [GPGPU][PPCGCodeGen][GPUJIT] Added AMD support to GPGPU code generation.

I agree, it is a really 'disgusting' hack at this point.

  • So the reason lld is used instead of ld is simply that I do not know and have not been able to test if ld works. The AMDGPU backend documentation here specifically mentions lld, so I felt like that was the safest bet. But you are absolutely right, if ld works, that is the better default.
Sep 19 2017, 1:02 PM
PhilippSchaad added a comment to D37691: [GPUJIT] Improved temporary file handling..

Thank you both for the review!

Sep 19 2017, 3:19 AM

Sep 11 2017

PhilippSchaad created D37691: [GPUJIT] Improved temporary file handling..
Sep 11 2017, 8:00 AM

Sep 6 2017

PhilippSchaad updated the diff for D37429: [GPGPU][PPCGCodeGen][GPUJIT] Added AMD support to GPGPU code generation.
  • Improved temporary file handling.
  • Fixed error in test case
Sep 6 2017, 8:29 AM

Sep 3 2017

PhilippSchaad updated the diff for D37429: [GPGPU][PPCGCodeGen][GPUJIT] Added AMD support to GPGPU code generation.
  • Updated test cases to reflect changes and fixed formatting
Sep 3 2017, 12:24 PM
PhilippSchaad created D37429: [GPGPU][PPCGCodeGen][GPUJIT] Added AMD support to GPGPU code generation.
Sep 3 2017, 12:13 PM

Aug 27 2017

PhilippSchaad closed D37191: [Polly][GPGPU] Fixed undefined reference for CUDA's managed memory in Runtime library..

Was committed with https://llvm.org/svn/llvm-project/polly/trunk@311848 91177308-0d34-0410-b5e6-96231b3b80d8

Aug 27 2017, 6:34 AM
PhilippSchaad added a comment to D37191: [Polly][GPGPU] Fixed undefined reference for CUDA's managed memory in Runtime library..

Not a problem, thanks for reacting so quickly! :-)

Aug 27 2017, 4:59 AM
PhilippSchaad created D37191: [Polly][GPGPU] Fixed undefined reference for CUDA's managed memory in Runtime library..
Aug 27 2017, 4:54 AM

Aug 19 2017

PhilippSchaad created D36925: [PPCG] Only add Kernel argument sizes for OpenCL, not CUDA runtime.
Aug 19 2017, 9:45 AM
PhilippSchaad accepted D36921: [Polly] [GPUJIT] [Untested] Switch from Runtime API calls for managed memory to Driver API calls..

Thank you for the quick fix! I can confirm that it works.

Aug 19 2017, 8:24 AM

Jul 21 2017

PhilippSchaad updated the diff for D35185: [Polly][GPGPU] Added SPIR Code Generation and Corresponding Runtime Support for Intel.
Rebase for commit
Jul 21 2017, 8:52 AM · Restricted Project
PhilippSchaad added a comment to D35185: [Polly][GPGPU] Added SPIR Code Generation and Corresponding Runtime Support for Intel.

Ping do the latest changes address your concerns @singam-sanjay ? Can I land this?

Jul 21 2017, 3:37 AM · Restricted Project

Jul 17 2017

PhilippSchaad added inline comments to D35185: [Polly][GPGPU] Added SPIR Code Generation and Corresponding Runtime Support for Intel.
Jul 17 2017, 5:25 PM · Restricted Project
PhilippSchaad updated the diff for D35185: [Polly][GPGPU] Added SPIR Code Generation and Corresponding Runtime Support for Intel.

Removed left over debug print, moved SPIR creation into createASM, fixed minor issues addressed in comments.

Jul 17 2017, 5:18 PM · Restricted Project

Jul 16 2017

PhilippSchaad added a comment to D35185: [Polly][GPGPU] Added SPIR Code Generation and Corresponding Runtime Support for Intel.

Will address the points mentioned asap. As for your SPIR-V question: The goal, should that back-end be added, would be to add SPIR-V compilation as an additional GPU target option (In the future). This would allow kernel execution on any SPIR-V supporting target device. This SPIR solution is essentially a 'quickfix' to get it to work on Intel, as long as SPIR-V is not an option.

Jul 16 2017, 11:01 PM · Restricted Project

Jul 14 2017

PhilippSchaad updated the diff for D35185: [Polly][GPGPU] Added SPIR Code Generation and Corresponding Runtime Support for Intel.
  • Added testcase for SPIR
  • Fixed naming inconsistencies
Jul 14 2017, 10:40 AM · Restricted Project

Jul 11 2017

PhilippSchaad added inline comments to D35185: [Polly][GPGPU] Added SPIR Code Generation and Corresponding Runtime Support for Intel.
Jul 11 2017, 7:54 AM · Restricted Project
PhilippSchaad added a comment to D35185: [Polly][GPGPU] Added SPIR Code Generation and Corresponding Runtime Support for Intel.

I am not yet too familiar with how to implement such a case and what exactly to check for, but if that is desired, I can look into it.

Jul 11 2017, 7:51 AM · Restricted Project
PhilippSchaad updated the diff for D35185: [Polly][GPGPU] Added SPIR Code Generation and Corresponding Runtime Support for Intel.
  • Simplification
  • Removed compile-conditional CMake dependency
Jul 11 2017, 7:51 AM · Restricted Project
PhilippSchaad updated the diff for D35185: [Polly][GPGPU] Added SPIR Code Generation and Corresponding Runtime Support for Intel.
  • Removed Regexp hack
Jul 11 2017, 4:58 AM · Restricted Project
PhilippSchaad updated the diff for D35185: [Polly][GPGPU] Added SPIR Code Generation and Corresponding Runtime Support for Intel.
  • Added comment clarification for workaround.
Jul 11 2017, 4:19 AM · Restricted Project
PhilippSchaad added inline comments to D35185: [Polly][GPGPU] Added SPIR Code Generation and Corresponding Runtime Support for Intel.
Jul 11 2017, 4:17 AM · Restricted Project
PhilippSchaad updated the diff for D35185: [Polly][GPGPU] Added SPIR Code Generation and Corresponding Runtime Support for Intel.
  • Inserting SPIR barriers with custom function.
Jul 11 2017, 4:16 AM · Restricted Project

Jul 10 2017

PhilippSchaad updated the diff for D35185: [Polly][GPGPU] Added SPIR Code Generation and Corresponding Runtime Support for Intel.
  • Adapted dynamic method loading for intel
Jul 10 2017, 5:29 PM · Restricted Project
PhilippSchaad added inline comments to D35185: [Polly][GPGPU] Added SPIR Code Generation and Corresponding Runtime Support for Intel.
Jul 10 2017, 4:06 PM · Restricted Project

Jul 9 2017

PhilippSchaad updated the summary of D35185: [Polly][GPGPU] Added SPIR Code Generation and Corresponding Runtime Support for Intel.
Jul 9 2017, 11:53 AM · Restricted Project
PhilippSchaad added reviewers for D35185: [Polly][GPGPU] Added SPIR Code Generation and Corresponding Runtime Support for Intel: grosser, Meinersbur.
Jul 9 2017, 11:52 AM · Restricted Project
PhilippSchaad created D35185: [Polly][GPGPU] Added SPIR Code Generation and Corresponding Runtime Support for Intel.
Jul 9 2017, 11:51 AM · Restricted Project

May 10 2017

PhilippSchaad updated the diff for D33008: [Polly][GPUJIT] Disabled gcc's -Wpedantic for use of dlsym.

added reference

May 10 2017, 2:01 AM · Restricted Project

May 9 2017

PhilippSchaad created D33008: [Polly][GPUJIT] Disabled gcc's -Wpedantic for use of dlsym.
May 9 2017, 10:28 AM · Restricted Project
PhilippSchaad updated the diff for D32961: [Polly][PPCGCodeGen] OpenCL now gets kernel argument size from PPCG CodeGen.

Added constant identifier and mor idiomatic ArgSizes vector initialization

May 9 2017, 2:10 AM · Restricted Project
PhilippSchaad added a comment to D32961: [Polly][PPCGCodeGen] OpenCL now gets kernel argument size from PPCG CodeGen.

I personally find it better like this, because the i is per-loop, so it is self contained in every iteration, the Index however is across loops. To me, this way it is more clear, that the Index is not a loop-specific iteration variable.
Let's see what the others think though. Either way, I would suggest moving that to a different patch indeed, should we decide on changing that.

May 9 2017, 1:07 AM · Restricted Project

May 8 2017

PhilippSchaad updated the diff for D32961: [Polly][PPCGCodeGen] OpenCL now gets kernel argument size from PPCG CodeGen.

Addressed comments

May 8 2017, 10:43 AM · Restricted Project
PhilippSchaad updated the diff for D32961: [Polly][PPCGCodeGen] OpenCL now gets kernel argument size from PPCG CodeGen.
  • Addressed some comments.
May 8 2017, 2:01 AM · Restricted Project
PhilippSchaad added inline comments to D32961: [Polly][PPCGCodeGen] OpenCL now gets kernel argument size from PPCG CodeGen.
May 8 2017, 2:01 AM · Restricted Project
PhilippSchaad updated the diff for D32962: [Polly][GPUJIT] Fixed OpenCL 2.0 min requirement for Error codes.

Fixed wrong device queue error

May 8 2017, 1:32 AM · Restricted Project
PhilippSchaad created D32962: [Polly][GPUJIT] Fixed OpenCL 2.0 min requirement for Error codes.
May 8 2017, 1:30 AM · Restricted Project
PhilippSchaad updated the summary of D32961: [Polly][PPCGCodeGen] OpenCL now gets kernel argument size from PPCG CodeGen.
May 8 2017, 12:37 AM · Restricted Project
PhilippSchaad created D32961: [Polly][PPCGCodeGen] OpenCL now gets kernel argument size from PPCG CodeGen.
May 8 2017, 12:35 AM · Restricted Project

May 7 2017

PhilippSchaad updated the diff for D32431: [Polly] Added OpenCL Runtime to GPURuntime Library for GPGPU CodeGen.

Rebase

May 7 2017, 2:36 AM · Restricted Project
PhilippSchaad reopened D32431: [Polly] Added OpenCL Runtime to GPURuntime Library for GPGPU CodeGen.

Reopened for rebase

May 7 2017, 2:36 AM · Restricted Project
PhilippSchaad updated the diff for D32852: [Polly] [GPUJIT] Moved error prints to stderr.

Rebase

May 7 2017, 2:24 AM
PhilippSchaad updated the diff for D32854: [Polly] [GPUJIT] Adapted argument capitalization to fit standard.

Rebase

May 7 2017, 2:23 AM

May 4 2017

PhilippSchaad added inline comments to D32431: [Polly] Added OpenCL Runtime to GPURuntime Library for GPGPU CodeGen.
May 4 2017, 3:55 AM · Restricted Project
PhilippSchaad added a comment to D32431: [Polly] Added OpenCL Runtime to GPURuntime Library for GPGPU CodeGen.

@Meinersbur the unrelated changes you mentioned have been added/moved to D32852 and D32854.

May 4 2017, 3:48 AM · Restricted Project
PhilippSchaad updated the diff for D32431: [Polly] Added OpenCL Runtime to GPURuntime Library for GPGPU CodeGen.
  • Introduced PPCGCodeGeneration header file for simplicity
May 4 2017, 3:45 AM · Restricted Project
PhilippSchaad added a comment to D32431: [Polly] Added OpenCL Runtime to GPURuntime Library for GPGPU CodeGen.

Addressed most of your concerns. @grosser it should be ready now, what do you think?

May 4 2017, 3:45 AM · Restricted Project
PhilippSchaad created D32854: [Polly] [GPUJIT] Adapted argument capitalization to fit standard.
May 4 2017, 3:04 AM
PhilippSchaad created D32852: [Polly] [GPUJIT] Moved error prints to stderr.
May 4 2017, 2:58 AM

May 2 2017

PhilippSchaad updated the diff for D32431: [Polly] Added OpenCL Runtime to GPURuntime Library for GPGPU CodeGen.
  • Fixed formatting
May 2 2017, 1:37 PM · Restricted Project
PhilippSchaad updated the diff for D32431: [Polly] Added OpenCL Runtime to GPURuntime Library for GPGPU CodeGen.
  • Addressed multiple issues pointed out in comment
May 2 2017, 1:14 PM · Restricted Project
PhilippSchaad added inline comments to D32431: [Polly] Added OpenCL Runtime to GPURuntime Library for GPGPU CodeGen.
May 2 2017, 1:13 PM · Restricted Project
PhilippSchaad updated the diff for D32431: [Polly] Added OpenCL Runtime to GPURuntime Library for GPGPU CodeGen.
  • Fixed formatting and managed-memory test case (including pre-existing bug)
May 2 2017, 5:54 AM · Restricted Project

May 1 2017

PhilippSchaad added a comment to D32431: [Polly] Added OpenCL Runtime to GPURuntime Library for GPGPU CodeGen.

@grosser @Meinersbur ping

May 1 2017, 11:00 PM · Restricted Project

Apr 30 2017

PhilippSchaad updated the diff for D32431: [Polly] Added OpenCL Runtime to GPURuntime Library for GPGPU CodeGen.
  • Integrated D32226 - Managed memory support
Apr 30 2017, 3:48 AM · Restricted Project
PhilippSchaad added a reviewer for D32431: [Polly] Added OpenCL Runtime to GPURuntime Library for GPGPU CodeGen: singam-sanjay.
Apr 30 2017, 3:42 AM · Restricted Project

Apr 29 2017

PhilippSchaad added inline comments to D32431: [Polly] Added OpenCL Runtime to GPURuntime Library for GPGPU CodeGen.
Apr 29 2017, 9:37 AM · Restricted Project
PhilippSchaad updated the summary of D32431: [Polly] Added OpenCL Runtime to GPURuntime Library for GPGPU CodeGen.
Apr 29 2017, 8:14 AM · Restricted Project
PhilippSchaad added inline comments to D32431: [Polly] Added OpenCL Runtime to GPURuntime Library for GPGPU CodeGen.
Apr 29 2017, 7:40 AM · Restricted Project
PhilippSchaad added inline comments to D32431: [Polly] Added OpenCL Runtime to GPURuntime Library for GPGPU CodeGen.
Apr 29 2017, 6:40 AM · Restricted Project
PhilippSchaad updated the diff for D32431: [Polly] Added OpenCL Runtime to GPURuntime Library for GPGPU CodeGen.
  • GPURuntime works on systems with just one of CUDA/OpenCL now.
Apr 29 2017, 6:38 AM · Restricted Project

Apr 27 2017

PhilippSchaad added inline comments to D32431: [Polly] Added OpenCL Runtime to GPURuntime Library for GPGPU CodeGen.
Apr 27 2017, 7:49 AM · Restricted Project
PhilippSchaad updated the diff for D32431: [Polly] Added OpenCL Runtime to GPURuntime Library for GPGPU CodeGen.
  • Fixed enum style to C++11
Apr 27 2017, 5:02 AM · Restricted Project

Apr 26 2017

PhilippSchaad updated the diff for D32431: [Polly] Added OpenCL Runtime to GPURuntime Library for GPGPU CodeGen.
  • Made CUDA Runtime default, fixed formatting, adapted test case
Apr 26 2017, 4:43 AM · Restricted Project
PhilippSchaad updated the summary of D32431: [Polly] Added OpenCL Runtime to GPURuntime Library for GPGPU CodeGen.
Apr 26 2017, 3:19 AM · Restricted Project
PhilippSchaad updated the diff for D32431: [Polly] Added OpenCL Runtime to GPURuntime Library for GPGPU CodeGen.
  • Addressed consistency and naming concerns
Apr 26 2017, 3:07 AM · Restricted Project

Apr 25 2017

PhilippSchaad added a comment to D32431: [Polly] Added OpenCL Runtime to GPURuntime Library for GPGPU CodeGen.

Looking into the rest of your comments.

Apr 25 2017, 11:34 PM · Restricted Project
PhilippSchaad updated the diff for D32431: [Polly] Added OpenCL Runtime to GPURuntime Library for GPGPU CodeGen.
  • Removed left over commented out macros
Apr 25 2017, 12:23 PM · Restricted Project
PhilippSchaad updated the diff for D32431: [Polly] Added OpenCL Runtime to GPURuntime Library for GPGPU CodeGen.
  • Stylistic changes and switch to -polly-gpu-runtime=cuda/opencl compiler flag
Apr 25 2017, 12:18 PM · Restricted Project
PhilippSchaad added inline comments to D32431: [Polly] Added OpenCL Runtime to GPURuntime Library for GPGPU CodeGen.
Apr 25 2017, 9:45 AM · Restricted Project
PhilippSchaad added inline comments to D32431: [Polly] Added OpenCL Runtime to GPURuntime Library for GPGPU CodeGen.
Apr 25 2017, 9:38 AM · Restricted Project
PhilippSchaad added a comment to D32431: [Polly] Added OpenCL Runtime to GPURuntime Library for GPGPU CodeGen.

I wrote a runtime with similar scope here: https://github.com/Meinersbur/prl . We were one discussing to use it for Polly as well. What's the status of that?

Apr 25 2017, 9:34 AM · Restricted Project
PhilippSchaad added a comment to D32215: Updated PPCG Code Generation for OpenCL compatibility.

@bollu ping: I would love it if you could commit this change please ;-)

Apr 25 2017, 12:46 AM · Restricted Project
PhilippSchaad added reviewers for D32431: [Polly] Added OpenCL Runtime to GPURuntime Library for GPGPU CodeGen: Meinersbur, etherzhhb.
Apr 25 2017, 12:39 AM · Restricted Project

Apr 24 2017

PhilippSchaad updated the diff for D32431: [Polly] Added OpenCL Runtime to GPURuntime Library for GPGPU CodeGen.
  • Replaced magic numbers, added assertions and fixed if-braces.
Apr 24 2017, 7:16 AM · Restricted Project
PhilippSchaad updated subscribers of D32431: [Polly] Added OpenCL Runtime to GPURuntime Library for GPGPU CodeGen.
Apr 24 2017, 6:45 AM · Restricted Project
PhilippSchaad retitled D32431: [Polly] Added OpenCL Runtime to GPURuntime Library for GPGPU CodeGen from Added OpenCL Runtime to GPURuntime Library for GPGPU CodeGen to [Polly] Added OpenCL Runtime to GPURuntime Library for GPGPU CodeGen.
Apr 24 2017, 6:44 AM · Restricted Project
PhilippSchaad created D32431: [Polly] Added OpenCL Runtime to GPURuntime Library for GPGPU CodeGen.
Apr 24 2017, 6:39 AM · Restricted Project
PhilippSchaad added a comment to D32215: Updated PPCG Code Generation for OpenCL compatibility.

@bollu Could you maybe land this when @grosser agrees with the revert?

Apr 24 2017, 3:25 AM · Restricted Project
PhilippSchaad updated the diff for D32215: Updated PPCG Code Generation for OpenCL compatibility.

Reverted unnecessary datalayout changes in tests.

Apr 24 2017, 3:22 AM · Restricted Project
PhilippSchaad added inline comments to D32215: Updated PPCG Code Generation for OpenCL compatibility.
Apr 24 2017, 3:07 AM · Restricted Project
PhilippSchaad updated the diff for D32215: Updated PPCG Code Generation for OpenCL compatibility.

Removed magic constant in favor of more doc-friendly 'explanatory-constant'.

Apr 24 2017, 2:28 AM · Restricted Project
PhilippSchaad added inline comments to D32215: Updated PPCG Code Generation for OpenCL compatibility.
Apr 24 2017, 2:21 AM · Restricted Project
PhilippSchaad added a comment to D32215: Updated PPCG Code Generation for OpenCL compatibility.

@grosser @bollu ping

Apr 24 2017, 2:19 AM · Restricted Project
PhilippSchaad accepted D32226: [Polly] [PPCGCodeGeneration] Add managed memory support to GPU code generation..
Apr 24 2017, 1:02 AM
PhilippSchaad added a reviewer for D32215: Updated PPCG Code Generation for OpenCL compatibility: Meinersbur.
Apr 24 2017, 12:59 AM · Restricted Project

Apr 23 2017

PhilippSchaad added a comment to D32215: Updated PPCG Code Generation for OpenCL compatibility.

Am I wrong on this?

No, it looks like I was wrong and you are correct.

Sorry about that.

Apr 23 2017, 10:36 AM · Restricted Project
PhilippSchaad added a comment to D32215: Updated PPCG Code Generation for OpenCL compatibility.

@jlebar From what I understand, NVPTX only marks a kernel argument as .global if its address space in the IR has been marked with addrspace(1), and said conversion to global address space would then take place inside the kernel, instead of marking the argument itself with .global. Am I wrong on this?

Apr 23 2017, 2:25 AM · Restricted Project

Apr 22 2017

PhilippSchaad added a comment to D32215: Updated PPCG Code Generation for OpenCL compatibility.

Additionally, all parameters have been adapted to be global pointers.

FYI, the LLVM backend has a pass that converts kernel args to address space 1 -- it's not necessary for front-ends to do this. Depending on what you're doing in these tests it may or may not be necessary -- I can't check because this patch was uploaded without context.

Apr 22 2017, 10:17 AM · Restricted Project
PhilippSchaad updated the diff for D32215: Updated PPCG Code Generation for OpenCL compatibility.

Updated tests to fit address space changes and correct NVPTX data layout.

Apr 22 2017, 3:58 AM · Restricted Project

Apr 20 2017

PhilippSchaad added inline comments to D32215: Updated PPCG Code Generation for OpenCL compatibility.
Apr 20 2017, 10:01 AM · Restricted Project
PhilippSchaad updated the diff for D32215: Updated PPCG Code Generation for OpenCL compatibility.
Apr 20 2017, 9:30 AM · Restricted Project
PhilippSchaad added a comment to D32226: [Polly] [PPCGCodeGeneration] Add managed memory support to GPU code generation..

Using the modified Polybench/C I can confirm that it's working. When respecting those necessary changes, this patch looks good to me.

Apr 20 2017, 4:07 AM
PhilippSchaad added a comment to D32226: [Polly] [PPCGCodeGeneration] Add managed memory support to GPU code generation..

Hi Siddharth

Apr 20 2017, 3:15 AM

Apr 19 2017

PhilippSchaad updated subscribers of D32215: Updated PPCG Code Generation for OpenCL compatibility.
Apr 19 2017, 1:35 AM · Restricted Project
PhilippSchaad created D32215: Updated PPCG Code Generation for OpenCL compatibility.
Apr 19 2017, 1:28 AM · Restricted Project