- Insert AMD macro
- Insert AMDGPU macro
- Insert devicename macro
- Add missing tests for arch macros
Details
Diff Detail
Event Timeline
lib/Basic/Targets/AMDGPU.cpp | ||
---|---|---|
345–348 | Should this be the following since extra macros could be after it in the future: if (!GPUName.empty()) Builder.defineMacro(Twine("__") + Twine(GPUName) + Twine("__")); Should we only be defining macros using the canonical target name (the one in column 1 of https://llvm.org/docs/AMDGPUUsage.html#processors) rather than the one specified on the command line? |
lib/Basic/Targets/AMDGPU.cpp | ||
---|---|---|
337 | At the meeting we discussed defining every alias of the given GPU, rather than only the mcpu name. Were we going to proceed with that? |
lib/Basic/Targets/AMDGPU.cpp | ||
---|---|---|
336 | Subsequent discussion decided to drop this macro. | |
337 | Subsequent discussion settled on only defining the canonical names. If it was useful to also have the alternative names a header file could be provided that defines those names in response to the canonical names being defined. |
Subsequent discussion decided to drop this macro.