Page MenuHomePhabricator

Enable COMPILER_RT_HAS_SANITIZER_COMMON on NetBSD
ClosedPublic

Authored by krytarowski on Aug 4 2017, 8:03 AM.

Details

Summary

Temporarily keep disabled COMPILER_RT_HAS_ASAN on NetBSD.

Part of the code inspired by the original work on libsanitizer in GCC 5.4 by Christos Zoulas.

Sponsored by <The NetBSD Foundation>

Diff Detail

Repository
rL LLVM

Event Timeline

krytarowski created this revision.Aug 4 2017, 8:03 AM
vitalybuka edited edge metadata.Aug 4 2017, 2:38 PM

Why do you temporarily disable it?

Why do you temporarily disable it?

ASAN requires additional code, that I will push after upstreaming common-sanitizer and later ubsan.

vitalybuka accepted this revision.Aug 4 2017, 3:45 PM
This revision is now accepted and ready to land.Aug 4 2017, 3:45 PM

I will hold on with committing this until merging all the remaining patches for COMPILER_RT_HAS_SANITIZER_COMMON.

All the patches are pending upstream. All tests pass for "check-sanitizer"* on NetBSD/amd64.

  • however there are might be some races and few tests randomly fail sometimes - I will investigate it later.

2 patches to be reviewed left.. I'm going to commit it now, soon I will prompt for enabling asan.

krytarowski closed this revision.Aug 8 2017, 8:26 AM