[lit] check-lit compatibility with multi-config CMake generators

[gbedwell]

Summary

Multi-configuration CMake generators such as Visual Studio or Xcode do not
specify a build config at configure time, but let the user choose at build
time.  In these cases binaries go into bin/${Configuration} rather than
bin/.  Prior to this commit, check-lit would fail when using multi-configuration
generators as it did not know how to resolve bin/${Configuration} in order
to find tools such as FileCheck.  This commit teaches it to resolve
llvm_tools_dir within lit using the value specified with --param
build_mode.

This commit supersedes D36212 after discussion in that review. Essentially we're just using the strategy seen elsewhere to deal with this issue (e.g. llvm/test/Unit )

[chapuni]

Looks good, but I don't have environments to check actually.

[vleschuk]

LGTM

llvm/trunk/utils/lit/CMakeLists.txt

 # The configured file is not placed in the correct location
 # until the tests are run as we need to copy it into
 # a copy of the tests folder
-configure_file("tests/lit.site.cfg.in" "lit.site.cfg" @ONLY)
+configure_lit_site_cfg("tests/lit.site.cfg.in" "lit.site.cfg")
 
 # Lit's test suite creates output files next to the sources which makes the
 # source tree dirty. This is undesirable because we do out of source builds.
 # To work around this the tests and the configuration file are copied into the
 # build directory just before running them. The tests are not copied over at
 # configure time (i.e. `file(COPY ...)`) because this could lead to stale
 # tests being run.
 add_custom_target(prepare-check-lit

llvm/trunk/utils/lit/tests/lit.site.cfg.in

-## Autogenerated by LLVM/Clang configuration.
-# Do not edit!
+@LIT_SITE_CFG_IN_HEADER@
+
+import sys
+
 config.llvm_src_root = "@LLVM_SOURCE_DIR@"
 config.llvm_obj_root = "@LLVM_BINARY_DIR@"
-config.llvm_tools_dir = "@LLVM_TOOLS_BINARY_DIR@"
+config.llvm_tools_dir = "@LLVM_TOOLS_DIR@"
+
+# Support substitution of the tools_dir with user parameters.
+# This is used when we can't determine the tool dir at configuration time.
+try:
+    config.llvm_tools_dir = config.llvm_tools_dir % lit_config.params
+except KeyError:
+    e = sys.exc_info()[1]
+    key, = e.args
+    lit_config.fatal("unable to find %r parameter, use '--param=%s=VALUE'" % (key,key))
 
 # Let the main config do the real work.
 lit_config.load_config(config, "@LLVM_BINARY_DIR@/utils/lit/tests/lit.cfg")