Page MenuHomePhabricator

vleschuk (Victor Leschuk)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 21 2016, 2:34 AM (152 w, 5 d)

Recent Activity

Sep 11 2018

vleschuk added a comment to D51081: [DWARF v5] Refactoring range list dumping to fold DWARF v4 functionality into v5 handling (almost NFC)..

@wolfgangp do you need any help with this revision before you commit it?

Sep 11 2018, 12:19 PM

Aug 30 2018

vleschuk added a comment to D51081: [DWARF v5] Refactoring range list dumping to fold DWARF v4 functionality into v5 handling (almost NFC)..

@vleschuk: Let me know what you think about this. I understand your suggestion but this seems a bit simpler to me.

Aug 30 2018, 11:15 PM

Aug 29 2018

vleschuk added inline comments to D51081: [DWARF v5] Refactoring range list dumping to fold DWARF v4 functionality into v5 handling (almost NFC)..
Aug 29 2018, 8:41 PM

Aug 27 2018

vleschuk accepted D51081: [DWARF v5] Refactoring range list dumping to fold DWARF v4 functionality into v5 handling (almost NFC)..

LGTM

Aug 27 2018, 12:33 PM

Aug 26 2018

vleschuk added inline comments to D51081: [DWARF v5] Refactoring range list dumping to fold DWARF v4 functionality into v5 handling (almost NFC)..
Aug 26 2018, 10:37 PM

Aug 24 2018

vleschuk added inline comments to D51081: [DWARF v5] Refactoring range list dumping to fold DWARF v4 functionality into v5 handling (almost NFC)..
Aug 24 2018, 7:25 AM

Aug 23 2018

vleschuk committed rL340528: [DWARF] Unify warning callbacks. NFC..
[DWARF] Unify warning callbacks. NFC.
Aug 23 2018, 5:44 AM
vleschuk closed D51033: [DWARF] Move error printing from DWARF classes to Support library. NFC..
Aug 23 2018, 5:44 AM · debug-info
vleschuk added inline comments to D51081: [DWARF v5] Refactoring range list dumping to fold DWARF v4 functionality into v5 handling (almost NFC)..
Aug 23 2018, 2:32 AM

Aug 22 2018

vleschuk added a comment to D51033: [DWARF] Move error printing from DWARF classes to Support library. NFC..

@jhenderson Here is the variant where dumpWarning() lives in DWARFContext. Patch became much simpler and smaller. What do you think?

Aug 22 2018, 11:48 AM · debug-info
vleschuk updated the diff for D51033: [DWARF] Move error printing from DWARF classes to Support library. NFC..
  • Removed all functions from Support library in order not to tempt other Support users
  • dumpWarning() now lives in DWARFContext
  • Had to get rid of default callbacks in DebugLine and DebugAddr to avoid circular dependency with DWARFContext
Aug 22 2018, 11:47 AM · debug-info
vleschuk added a comment to D51033: [DWARF] Move error printing from DWARF classes to Support library. NFC..

I'm thinking a bit more about this and I'm concerned that by adding these functions to Error.h, people will be more likely to use them from libraries, which can lead to various issues when the client of the library doesn't want to report errors and warnings the same way as this implements. The warn function was really only intended as a default implementation so that we didn't have to propagate things all the way out of DWARFContext.cpp, for the single client (llvm-dwarfdump) to consume.

Aug 22 2018, 5:06 AM · debug-info

Aug 21 2018

vleschuk added inline comments to D51033: [DWARF] Move error printing from DWARF classes to Support library. NFC..
Aug 21 2018, 8:49 AM · debug-info
vleschuk added inline comments to D51033: [DWARF] Move error printing from DWARF classes to Support library. NFC..
Aug 21 2018, 8:37 AM · debug-info
vleschuk updated the diff for D51033: [DWARF] Move error printing from DWARF classes to Support library. NFC..
  • Changed names of functions from Display* to dump*
  • Changed comments
  • Got rid of unrelated whitespace change
  • Manually fixed indentation when clang-format suggested smth strange
Aug 21 2018, 6:09 AM · debug-info
vleschuk added inline comments to D51033: [DWARF] Move error printing from DWARF classes to Support library. NFC..
Aug 21 2018, 5:50 AM · debug-info
vleschuk added a comment to D51033: [DWARF] Move error printing from DWARF classes to Support library. NFC..

I'm not convinced "Display" is the right term for the message. "Print" or "Dump" would be much more typical for reporting messages.

Aug 21 2018, 5:47 AM · debug-info
vleschuk added inline comments to D51033: [DWARF] Move error printing from DWARF classes to Support library. NFC..
Aug 21 2018, 5:25 AM · debug-info
vleschuk created D51033: [DWARF] Move error printing from DWARF classes to Support library. NFC..
Aug 21 2018, 5:23 AM · debug-info

Aug 20 2018

vleschuk committed rL340163: [DWARF] Refactor DWARF classes to use unified error reporting. NFC..
[DWARF] Refactor DWARF classes to use unified error reporting. NFC.
Aug 20 2018, 3:00 AM
vleschuk closed D49964: [DWARF] Refactor DWARF classes to use unified error reporting. NFC..
Aug 20 2018, 3:00 AM · debug-info

Aug 19 2018

vleschuk added a comment to D49964: [DWARF] Refactor DWARF classes to use unified error reporting. NFC..

@jhenderson Please take a look when you have time.

Aug 19 2018, 3:47 AM · debug-info
vleschuk updated the diff for D49964: [DWARF] Refactor DWARF classes to use unified error reporting. NFC..
  • Changed error codes to more appropriate ones
  • Fixed formatting
Aug 19 2018, 3:46 AM · debug-info
vleschuk added a comment to D49964: [DWARF] Refactor DWARF classes to use unified error reporting. NFC..

I just noticed that llvmObject has an object_error equivalent to std::errc, with a make_error_code method allowing us to turn them into std::error_code for use with the new function. In particular, there are unexpected_eof and parser_failed errors, which might be more appropriate for certain situations in this file. What do you think?

Aug 19 2018, 3:32 AM · debug-info
vleschuk added inline comments to D49964: [DWARF] Refactor DWARF classes to use unified error reporting. NFC..
Aug 19 2018, 3:26 AM · debug-info

Aug 16 2018

vleschuk added a comment to D49964: [DWARF] Refactor DWARF classes to use unified error reporting. NFC..

Hi @vleschuk, I just wanted to quickly check-in on this to see if you need any help with making further improvements as suggested?

Aug 16 2018, 11:38 PM · debug-info

Aug 1 2018

vleschuk added a comment to D49964: [DWARF] Refactor DWARF classes to use unified error reporting. NFC..

Ping. Any questions?

Aug 1 2018, 10:25 PM · debug-info

Jul 31 2018

vleschuk committed rL338487: [DWARF] Basic support for producing DWARFv5 .debug_addr section.
[DWARF] Basic support for producing DWARFv5 .debug_addr section
Jul 31 2018, 10:48 PM
vleschuk closed D50005: [DWARF] Basic support for producing DWARFv5 .debug_addr section.
Jul 31 2018, 10:48 PM · debug-info
vleschuk closed D49676: [DWARF] support for .debug_addr (consumer).

Closed by rL338447

Jul 31 2018, 10:22 PM · debug-info
vleschuk committed rL338447: [DWARF] Support for .debug_addr (consumer).
[DWARF] Support for .debug_addr (consumer)
Jul 31 2018, 3:19 PM
vleschuk added inline comments to D49676: [DWARF] support for .debug_addr (consumer).
Jul 31 2018, 2:43 PM · debug-info
vleschuk added inline comments to D49964: [DWARF] Refactor DWARF classes to use unified error reporting. NFC..
Jul 31 2018, 11:09 AM · debug-info
vleschuk added a comment to D49676: [DWARF] support for .debug_addr (consumer).

Okay, I think I'm happy with this, but please let the others give their feedback and thumbs up too.

@aprantl , @dblaikie , @probinson, do you have any objections on this?

Have you considered writing unit tests for this at all? I don't think they're strictly necessary, but they would be nice.

I thought about it, I will give it more thought when we have more mature implementation.

Jul 31 2018, 8:27 AM · debug-info
vleschuk updated the diff for D49676: [DWARF] support for .debug_addr (consumer).
  • Fixed spacing in tests
  • Minor grammar fixes in comments
Jul 31 2018, 8:25 AM · debug-info
vleschuk updated the diff for D49676: [DWARF] support for .debug_addr (consumer).
  • Fixed comments and gaps between lines.
  • Moved get-by-index implementation from header to cpp.
  • Added default value to DumpOptions.
Jul 31 2018, 8:06 AM · debug-info
vleschuk added inline comments to D49676: [DWARF] support for .debug_addr (consumer).
Jul 31 2018, 8:03 AM · debug-info
vleschuk added a comment to D49964: [DWARF] Refactor DWARF classes to use unified error reporting. NFC..

Does anyone have more questions/suggestions/objections on this revision?

Jul 31 2018, 7:38 AM · debug-info
vleschuk added inline comments to D49676: [DWARF] support for .debug_addr (consumer).
Jul 31 2018, 4:13 AM · debug-info
vleschuk updated the diff for D49676: [DWARF] support for .debug_addr (consumer).
  • Added FIXME comment for version mismatch situation
  • Added check for the version <= 5 and corresponding test.
Jul 31 2018, 4:12 AM · debug-info
vleschuk added inline comments to D49676: [DWARF] support for .debug_addr (consumer).
Jul 31 2018, 4:08 AM · debug-info

Jul 30 2018

vleschuk added inline comments to D50005: [DWARF] Basic support for producing DWARFv5 .debug_addr section.
Jul 30 2018, 11:17 PM · debug-info
vleschuk updated the diff for D50005: [DWARF] Basic support for producing DWARFv5 .debug_addr section.
  • Adopted producer test to match recent changes (got rid of "params" from "Addr Section params" message).
  • Removed explicit return from test sample
  • Moved header emission to AddressPool class
Jul 30 2018, 11:14 PM · debug-info
vleschuk added inline comments to D50005: [DWARF] Basic support for producing DWARFv5 .debug_addr section.
Jul 30 2018, 11:11 PM · debug-info
vleschuk updated the diff for D49676: [DWARF] support for .debug_addr (consumer).

As mentioned in https://reviews.llvm.org/D50005 changed "header" message:

Jul 30 2018, 10:30 PM · debug-info
vleschuk updated the diff for D50005: [DWARF] Basic support for producing DWARFv5 .debug_addr section.

This revision implements support for generating DWARFv5 .debug_addr section. It is dependent on https://reviews.llvm.org/D49676 as we need working consumer to execute test.

Jul 30 2018, 12:59 PM · debug-info
vleschuk added a parent revision for D50005: [DWARF] Basic support for producing DWARFv5 .debug_addr section: D49676: [DWARF] support for .debug_addr (consumer).
Jul 30 2018, 12:53 PM · debug-info
vleschuk added a child revision for D49676: [DWARF] support for .debug_addr (consumer): D50005: [DWARF] Basic support for producing DWARFv5 .debug_addr section.
Jul 30 2018, 12:53 PM · debug-info
vleschuk removed a child revision for D50005: [DWARF] Basic support for producing DWARFv5 .debug_addr section: D49676: [DWARF] support for .debug_addr (consumer).
Jul 30 2018, 12:53 PM · debug-info
vleschuk removed a parent revision for D49676: [DWARF] support for .debug_addr (consumer): D50005: [DWARF] Basic support for producing DWARFv5 .debug_addr section.
Jul 30 2018, 12:53 PM · debug-info
vleschuk added a parent revision for D49676: [DWARF] support for .debug_addr (consumer): D50005: [DWARF] Basic support for producing DWARFv5 .debug_addr section.
Jul 30 2018, 12:51 PM · debug-info
vleschuk added a child revision for D50005: [DWARF] Basic support for producing DWARFv5 .debug_addr section: D49676: [DWARF] support for .debug_addr (consumer).
Jul 30 2018, 12:51 PM · debug-info
vleschuk created D50005: [DWARF] Basic support for producing DWARFv5 .debug_addr section.
Jul 30 2018, 12:50 PM · debug-info
vleschuk added inline comments to D49964: [DWARF] Refactor DWARF classes to use unified error reporting. NFC..
Jul 30 2018, 11:03 AM · debug-info
vleschuk updated the diff for D49676: [DWARF] support for .debug_addr (consumer).
  • Remove unnecessary warnings from tests
  • Separated test for 64bit addresses
  • Explicit length invalidation in clear()
  • Explicit clear() before extraction
  • Style and comment fixes
  • Rename debug_addr_size_not_multiple.s ==> debug_addr_address_size_not_multiple.s and debug_addr_size_not_multiple.s ==> debug_addr_address_size_not_multiple.s
Jul 30 2018, 4:46 AM · debug-info
vleschuk added inline comments to D49676: [DWARF] support for .debug_addr (consumer).
Jul 30 2018, 4:44 AM · debug-info
vleschuk added inline comments to D49676: [DWARF] support for .debug_addr (consumer).
Jul 30 2018, 3:25 AM · debug-info
vleschuk added inline comments to D49964: [DWARF] Refactor DWARF classes to use unified error reporting. NFC..
Jul 30 2018, 2:47 AM · debug-info

Jul 29 2018

vleschuk abandoned D30448: [DebugInfo] Show implicit_const values when dumping .debug_info section.
Jul 29 2018, 11:08 PM
vleschuk abandoned D30378: [DebugInfo] [DWARFv5] Collect calling convention info for C++ types during codegen.
Jul 29 2018, 11:07 PM
vleschuk abandoned D30377: [DebugInfo] [DWARFv5] Support for DW_AT_calling_convention for types.
Jul 29 2018, 11:07 PM
vleschuk abandoned D23168: emit_DW_AT_noreturn flag.
Jul 29 2018, 11:06 PM

Jul 28 2018

vleschuk added inline comments to D49964: [DWARF] Refactor DWARF classes to use unified error reporting. NFC..
Jul 28 2018, 11:10 PM · debug-info
vleschuk added a reviewer for D49964: [DWARF] Refactor DWARF classes to use unified error reporting. NFC.: wolfgangp.
Jul 28 2018, 11:07 PM · debug-info
vleschuk created D49964: [DWARF] Refactor DWARF classes to use unified error reporting. NFC..
Jul 28 2018, 11:04 PM · debug-info

Jul 27 2018

vleschuk updated the diff for D49676: [DWARF] support for .debug_addr (consumer).
  • More verbose error messages
  • Fixes for comment style
  • New test for the situation when section size too small for given length
Jul 27 2018, 8:40 PM · debug-info
vleschuk added inline comments to D49676: [DWARF] support for .debug_addr (consumer).
Jul 27 2018, 8:30 PM · debug-info
vleschuk added a comment to D49676: [DWARF] support for .debug_addr (consumer).

Also - I know for DW_AT_ranges attributes we have some advanced dumping in some situations that can print section names and the like, I think? Could we reuse that here too so the dumped addresses also have section name+offset, perhaps?

Sorry, actually I don't see this functionality for DW_AT_ranges, could you please tell me where I missed it?

Oh, sure - it was added here: https://reviews.llvm.org/D36313

Jul 27 2018, 7:08 PM · debug-info
vleschuk updated the diff for D49676: [DWARF] support for .debug_addr (consumer).

Changed errc::function_not_supported to errc::not_supported.

Jul 27 2018, 2:24 AM · debug-info
vleschuk added inline comments to D49676: [DWARF] support for .debug_addr (consumer).
Jul 27 2018, 2:17 AM · debug-info
vleschuk committed rL338114: [Support] Bring std::errc::not_supported to llvm::errc..
[Support] Bring std::errc::not_supported to llvm::errc.
Jul 27 2018, 2:15 AM
vleschuk updated the diff for D49676: [DWARF] support for .debug_addr (consumer).
  • Added more tests to verify all generated error messages
  • Added invalidateLength() method to DebugAddrTable class to mark the point when we need to stop extraction
  • Added support for dumping 64bit addresses
Jul 27 2018, 1:58 AM · debug-info
vleschuk added inline comments to D49676: [DWARF] support for .debug_addr (consumer).
Jul 27 2018, 1:52 AM · debug-info

Jul 26 2018

vleschuk updated the diff for D49676: [DWARF] support for .debug_addr (consumer).
  • Used new createStringError() function
  • Shortened tests and added new trivial test-case w/o .debug_addr section
  • Used getMaxVersion() to guess which version of .debug_addr we are looking at
  • Fixed comment and style issues
Jul 26 2018, 12:45 AM · debug-info

Jul 25 2018

vleschuk committed rL337995: [Support] Introduce createStringError helper function.
[Support] Introduce createStringError helper function
Jul 25 2018, 7:22 PM
vleschuk closed D49824: [Support] Introduce createStringError helper function.
Jul 25 2018, 7:22 PM
vleschuk added a parent revision for D49824: [Support] Introduce createStringError helper function: D49676: [DWARF] support for .debug_addr (consumer).
Jul 25 2018, 6:38 PM
vleschuk added a child revision for D49676: [DWARF] support for .debug_addr (consumer): D49824: [Support] Introduce createStringError helper function.
Jul 25 2018, 6:38 PM · debug-info
vleschuk removed a parent revision for D49676: [DWARF] support for .debug_addr (consumer): D49824: [Support] Introduce createStringError helper function.
Jul 25 2018, 6:38 PM · debug-info
vleschuk removed a child revision for D49824: [Support] Introduce createStringError helper function: D49676: [DWARF] support for .debug_addr (consumer).
Jul 25 2018, 6:38 PM
vleschuk added a parent revision for D49676: [DWARF] support for .debug_addr (consumer): D49824: [Support] Introduce createStringError helper function.
Jul 25 2018, 6:37 PM · debug-info
vleschuk added a child revision for D49824: [Support] Introduce createStringError helper function: D49676: [DWARF] support for .debug_addr (consumer).
Jul 25 2018, 6:37 PM
vleschuk updated the diff for D49824: [Support] Introduce createStringError helper function.

Added overloaded version of createStringError() function which is not variadic, also added corresponding test.

Jul 25 2018, 5:59 PM
vleschuk updated the diff for D49824: [Support] Introduce createStringError helper function.

Added explicit std::error_code param to createStringError() function.

Jul 25 2018, 5:24 PM
vleschuk added a comment to D49824: [Support] Introduce createStringError helper function.

Can you add a test for the case where no Vals are provided? I remember something about that requiring an overload without the variadic template arguments.

Jul 25 2018, 4:32 PM
vleschuk added inline comments to D49676: [DWARF] support for .debug_addr (consumer).
Jul 25 2018, 3:52 PM · debug-info
vleschuk created D49824: [Support] Introduce createStringError helper function.
Jul 25 2018, 3:51 PM
vleschuk updated the diff for D49676: [DWARF] support for .debug_addr (consumer).
  • Added support for pre-DWARFv5 .debug_addr format (e.g. w/o header)
  • Shortened .debug_addr consumer tests
  • Moved createError() implementation to llvm::Support
  • Relocated dumping above range_list dump
  • Moved table length verification inside AddrTable class
  • Renamed length() -> getLength()
  • Shortened comments
  • Fixed mistype in error message
Jul 25 2018, 3:11 AM · debug-info
vleschuk added a comment to D49676: [DWARF] support for .debug_addr (consumer).

What happens when dumping a file using pre-standard debug_addr? (is the version of the CU checked to make sure that the debug_addr section has a header, etc) I know this is super annoying - every time there's a section that lacks its own self-describing, versioned header, it hurts the ability to dump that section in the future :/ (in any object file that contains CUs of the old version that might have a contribution from that section, and thus cause entries in the section without a self-describing/standalone/versioned header)

Jul 25 2018, 2:30 AM · debug-info
vleschuk added inline comments to D49676: [DWARF] support for .debug_addr (consumer).
Jul 25 2018, 2:11 AM · debug-info
vleschuk added a comment to D49676: [DWARF] support for .debug_addr (consumer).

Not specific to your change, but I noticed that a lot of the DWARFContext code uses 32-bit offsets. Would it not make sense where we are writing new stuff, to use 64-bit offsets, since DWARF does support this?

Jul 25 2018, 1:15 AM · debug-info

Jul 23 2018

vleschuk created D49676: [DWARF] support for .debug_addr (consumer).
Jul 23 2018, 9:52 AM · debug-info

Feb 8 2018

vleschuk committed rL324706: [lit] Pass CLANG env var to testing configuration.
[lit] Pass CLANG env var to testing configuration
Feb 8 2018, 9:33 PM

Aug 30 2017

vleschuk committed rL312112: Revert r312105 [modules] Add ability to specify module name to module file….
Revert r312105 [modules] Add ability to specify module name to module file…
Aug 30 2017, 4:33 AM

Aug 24 2017

vleschuk committed rL311675: Remove duplicate code.
Remove duplicate code
Aug 24 2017, 10:04 AM
vleschuk committed rL311673: Add missing break in switch.
Add missing break in switch
Aug 24 2017, 9:59 AM

Aug 23 2017

vleschuk committed rL311560: Revert r311546 as it breaks build.
Revert r311546 as it breaks build
Aug 23 2017, 8:24 AM
vleschuk committed rL311558: Make lit :: shtest-format.py supported on Windows again.
Make lit :: shtest-format.py supported on Windows again
Aug 23 2017, 8:00 AM

Aug 20 2017

vleschuk accepted D36933: [buildbot] r310913 was missing a comma in the nt_flags config..

Sorry, I missed it too =) Please commit and I will reconfigure buildbot.

Aug 20 2017, 3:34 AM
vleschuk accepted rL310913: [buildbot] Raise the test-suite runtime limit for the avx512-sde builder..

Hello. I can restart in nearest two hours as it's Sunday.

Aug 20 2017, 12:45 AM