Page MenuHomePhabricator

[lit] check-lit compatibility with multi-config CMake generators
ClosedPublic

Authored by gbedwell on Aug 3 2017, 4:42 AM.

Details

Summary
Multi-configuration CMake generators such as Visual Studio or Xcode do not
specify a build config at configure time, but let the user choose at build
time.  In these cases binaries go into bin/${Configuration} rather than
bin/.  Prior to this commit, check-lit would fail when using multi-configuration
generators as it did not know how to resolve bin/${Configuration} in order
to find tools such as FileCheck.  This commit teaches it to resolve
llvm_tools_dir within lit using the value specified with --param
build_mode.

This commit supersedes D36212 after discussion in that review. Essentially we're just using the strategy seen elsewhere to deal with this issue (e.g. llvm/test/Unit )

Diff Detail

Repository
rL LLVM

Event Timeline

gbedwell edited the summary of this revision. (Show Details)Aug 3 2017, 4:45 AM
chapuni edited edge metadata.Aug 3 2017, 5:04 AM

Looks good, but I don't have environments to check actually.

vleschuk accepted this revision.Aug 3 2017, 5:09 AM
This revision is now accepted and ready to land.Aug 3 2017, 5:09 AM
modocache accepted this revision.Aug 3 2017, 8:06 AM
This revision was automatically updated to reflect the committed changes.