This is a continuation of https://reviews.llvm.org/D36219
This patch uses reverse mapping (encoding->name) in ARMInstPrinter::printBankedRegOperand to get rid of hard-coded values (as pointed out by @olista01).
Differential D36260
[ARM] Use searchable-table for banked registers javed.absar on Aug 3 2017, 12:57 AM. Authored by
Details This is a continuation of https://reviews.llvm.org/D36219 This patch uses reverse mapping (encoding->name) in ARMInstPrinter::printBankedRegOperand to get rid of hard-coded values (as pointed out by @olista01).
Diff Detail Event Timeline
Comment Actions LGTM with one nit.
|
How about using assert(TheReg && "invalid banked register operand"); instead of the if + assert + return ? The original code seems to behave similar to the assert (no early return in the error case)