This is an archive of the discontinued LLVM Phabricator instance.

[ARM|CodeGen] Improve the code in FastISel
ClosedPublic

Authored by javed.absar on Jul 17 2017, 10:40 AM.

Details

Summary

Cleaned up the code in FastISel a bit.

Had to add make_range to MCInstrDesc as that was needed and seems missing.

Diff Detail

Event Timeline

javed.absar created this revision.Jul 17 2017, 10:40 AM
t.p.northover accepted this revision.Jul 17 2017, 11:56 AM

Looks like a good change other than one nit. Feel free to commit with that fixed.

lib/Target/ARM/ARMFastISel.cpp
2236–2238

Commented code here.

This revision is now accepted and ready to land.Jul 17 2017, 11:56 AM

Thanks Tim. Will fix the commented code and commit.

This revision was automatically updated to reflect the committed changes.