This is an archive of the discontinued LLVM Phabricator instance.

[opt-viewer] Move under tools, install it
ClosedPublic

Authored by anemet on Jul 6 2017, 3:37 AM.

Details

Summary

We weren't installing opt-viewer and co before, this fixes the omission. I am
also moving the tools from utils/ to tools/. I believe that this is more
appropriate since these tools have matured greatly in the past year through
contributions by multiple people (thanks!) so they are ready to become
external tools.

The tools are installed under <install>/share/opt-viewer/.

I am *not* adding the llvm- prefix. If people feel strongly about adding
that, this is probably a good time since the new location will require some
mental adjustment anyway.

Fixes PR33521

Diff Detail

Repository
rL LLVM

Event Timeline

anemet created this revision.Jul 6 2017, 3:37 AM
davide accepted this revision.Jul 6 2017, 8:06 AM

I'm okay with or without the llvm-prefix.
I think it's useful for tools that have a GNU equivalent, but this one hasn't one, so, LGTM.

This revision is now accepted and ready to land.Jul 6 2017, 8:06 AM
bcain accepted this revision.Jul 6 2017, 8:36 AM

LGTM, thanks!

This revision was automatically updated to reflect the committed changes.
llvm/trunk/utils/opt-viewer/optrecord.py