Page MenuHomePhabricator

simon.f.whittaker (Simon Whittaker)


User does not belong to any projects.

User Details

User Since
Dec 14 2015, 1:13 PM (281 w, 3 d)

Recent Activity

Jun 29 2017

simon.f.whittaker added a comment to D34735: [opt-viewer] Add progress indicators (PR33522).

I had seen tqdm, but:

  1. I wasn't sure what you thought about taking on another dependency, so I erred on the safe side of no additional external dependencies
  2. Just printing "N of 1197" is good enough for me, it lets me get some feedback on whether the script is still working hard or whether it's stuck

Up to you, though! Happy to rewrite this with tqdm. My personal preference would be to merge as-is, and if someone wants to make a nicer-looking progress bar they're free to use tqdm.

Jun 29 2017, 10:29 AM

Jun 6 2016

simon.f.whittaker added a reviewer for D21047: [clang] Documentation fixes for LibASTMatchersTutorial: klimek.

Added Manuel Klimek at Sean's suggestion.

Jun 6 2016, 5:40 PM
simon.f.whittaker retitled D21047: [clang] Documentation fixes for LibASTMatchersTutorial from to [clang] Documentation fixes for LibASTMatchersTutorial.
Jun 6 2016, 5:27 PM