This is an archive of the discontinued LLVM Phabricator instance.

Differential D34835

[llvm-readobj] Improve printouts for COFF ARM64 binaries
ClosedPublic

Authored by mstorsjo on Jun 29 2017, 2:13 PM.

Details

Reviewers
mgrang
compnerd
Commits
rG43c854535efe: [llvm-readobj] Improve printouts for COFF ARM64 binaries
rL306795: [llvm-readobj] Improve printouts for COFF ARM64 binaries
Summary

Diff Detail

Event Timeline

mstorsjo created this revision.Jun 29 2017, 2:13 PM
Herald added subscribers: kristof.beyls, rengolin, aemerson. · View Herald TranscriptJun 29 2017, 2:13 PM
mstorsjo updated this revision to Diff 104745.Jun 29 2017, 2:54 PM
mstorsjo retitled this revision from [COFF] Classify AArch64 as 64 bit as well to [llvm-readobj] Improve printouts for COFF ARM64 binaries.
mstorsjo edited the summary of this revision. (Show Details)

Whoops, included the wrong diff previously.

Updated with tests and another printout correction.

Herald added a subscriber: javed.absar. · View Herald TranscriptJun 29 2017, 2:54 PM
compnerd accepted this revision.Jun 29 2017, 10:49 PM
This revision is now accepted and ready to land.Jun 29 2017, 10:49 PM
Closed by commit rL306795: [llvm-readobj] Improve printouts for COFF ARM64 binaries (authored by mstorsjo). · Explain WhyJun 30 2017, 12:02 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
tools/
llvm-readobj/
1 line

Diff 104734

tools/llvm-readobj/COFFDumper.cpp

Show First 20 Lines • Show All 672 Lines • ▼ Show 20 Linesvoid COFFDumper::printDOSHeader(const dos_header *DH) {
W.printNumber("OEMid", DH->OEMid); W.printNumber("OEMid", DH->OEMid);
W.printNumber("OEMinfo", DH->OEMinfo); W.printNumber("OEMinfo", DH->OEMinfo);
W.printNumber("AddressOfNewExeHeader", DH->AddressOfNewExeHeader); W.printNumber("AddressOfNewExeHeader", DH->AddressOfNewExeHeader);
} }
template <class PEHeader> template <class PEHeader>
void COFFDumper::printPEHeader(const PEHeader *Hdr) { void COFFDumper::printPEHeader(const PEHeader *Hdr) {
DictScope D(W, "ImageOptionalHeader"); DictScope D(W, "ImageOptionalHeader");
W.printNumber("Magic", Hdr->Magic);
W.printNumber("MajorLinkerVersion", Hdr->MajorLinkerVersion); W.printNumber("MajorLinkerVersion", Hdr->MajorLinkerVersion);
W.printNumber("MinorLinkerVersion", Hdr->MinorLinkerVersion); W.printNumber("MinorLinkerVersion", Hdr->MinorLinkerVersion);
W.printNumber("SizeOfCode", Hdr->SizeOfCode); W.printNumber("SizeOfCode", Hdr->SizeOfCode);
W.printNumber("SizeOfInitializedData", Hdr->SizeOfInitializedData); W.printNumber("SizeOfInitializedData", Hdr->SizeOfInitializedData);
W.printNumber("SizeOfUninitializedData", Hdr->SizeOfUninitializedData); W.printNumber("SizeOfUninitializedData", Hdr->SizeOfUninitializedData);
W.printHex ("AddressOfEntryPoint", Hdr->AddressOfEntryPoint); W.printHex ("AddressOfEntryPoint", Hdr->AddressOfEntryPoint);
W.printHex ("BaseOfCode", Hdr->BaseOfCode); W.printHex ("BaseOfCode", Hdr->BaseOfCode);
printBaseOfDataField(Hdr); printBaseOfDataField(Hdr);
▲ Show 20 Lines • Show All 1,144 Lines • Show Last 20 Lines