This is an archive of the discontinued LLVM Phabricator instance.

Fix the bug when handling shufflevector for aarch64.
ClosedPublic

Authored by danielcdh on Jun 26 2017, 1:07 PM.

Event Timeline

danielcdh created this revision.Jun 26 2017, 1:07 PM
mssimpso edited edge metadata.Jun 26 2017, 1:18 PM

Hi Dehao,

Thanks for fixing this. Can you move the test to Transforms/InterleavedAccess/AArch64/interleaved-accesses.ll and add some appropriate CHECK lines to make sure we're generating the correct code?

danielcdh updated this revision to Diff 104015.Jun 26 2017, 1:50 PM

move the test to Transforms/InterleavedAccess/AArch64/interleaved-accesses.ll

mssimpso accepted this revision.Jun 26 2017, 2:27 PM

LGTM.

This revision is now accepted and ready to land.Jun 26 2017, 2:27 PM
danielcdh closed this revision.Jun 26 2017, 2:33 PM
chandlerc added inline comments.
test/CodeGen/AArch64/pr33600.ll
1

Please actually run the output through FileCheck. This kind of test in particular you can almost certainly generate nice checks with the utils/update_llc_test_checks.py script.

1

Ignore this, I should learn to refresh my browser. Sorry for the noise.