This is an archive of the discontinued LLVM Phabricator instance.

[WebAssembly] Add support for weak symbols in the binary format
ClosedPublic

Authored by sbc100 on Jun 7 2017, 5:19 PM.

Event Timeline

sbc100 created this revision.Jun 7 2017, 5:19 PM
sbc100 edited the summary of this revision. (Show Details)Jun 14 2017, 10:25 AM
sbc100 added a reviewer: sunfish.
sunfish accepted this revision.Jun 16 2017, 1:46 PM

LGTM

include/llvm/ObjectYAML/WasmYAML.h
124 ↗(On Diff #102408)

This constructor can be marked explicit.

This revision is now accepted and ready to land.Jun 16 2017, 1:46 PM
sbc100 updated this revision to Diff 103128.Jun 19 2017, 5:55 PM
  • Reference symbols by name in linking section
sbc100 updated this revision to Diff 103142.Jun 19 2017, 9:03 PM
  • Explicit constructors
This revision was automatically updated to reflect the committed changes.
chapuni added inline comments.
llvm/trunk/lib/MC/WasmObjectWriter.cpp
1095 ↗(On Diff #103143)

Could we avoid leaving such a line, possibly snippet?