This is an archive of the discontinued LLVM Phabricator instance.

[codeview] respect signedness of APSInts when printing to YAML
ClosedPublic

Authored by inglorion on Jun 7 2017, 3:16 PM.

Details

Summary

This fixes a bug where we always treat APSInts in Codeview as
signed when writing them to YAML. One symptom of this problem is that
llvm-pdbdump raw would show Enumerator Values that differ between the
original PDB and a PDB that has been round-tripped through YAML.

Diff Detail

Repository
rL LLVM

Event Timeline

inglorion created this revision.Jun 7 2017, 3:16 PM
zturner accepted this revision.Jun 20 2017, 6:53 PM

I thought I lgtm'ed this already. Maybe I did it through email and it didn't show up? Anyway, sorry, lgtm

This revision is now accepted and ready to land.Jun 20 2017, 6:53 PM
This revision was automatically updated to reflect the committed changes.