This is an archive of the discontinued LLVM Phabricator instance.

Differential D33881

Remove duplicate LLVM_NATIVE_ from llvm's config.h
ClosedPublic

Authored by dim on Jun 4 2017, 12:21 PM.

Details

Reviewers
chandlerc
rnk
mehdi_amini
joerg
Commits
rG149378072456: Remove duplicate LLVM_NATIVE_ from llvm's config.h
rL304714: Remove duplicate LLVM_NATIVE_ from llvm's config.h
Summary

Since LLVM_NATIVE_ARCH, LLVM_NATIVE_ASMPARSER, LLVM_NATIVE_ASMPRINTER,
LLVM_NATIVE_DISASSEMBLER, LLVM_NATIVE_TARGET, LLVM_NATIVE_TARGETINFO and
LLVM_NATIVE_TARGETMC are already defined in llvm-config.h, there seems
to be no reason to also define them in config.h. Also, I can only find
usage of these macros in files that include llvm-config.h.

So let's remove the duplicated macros from config.h.

Diff Detail

Event Timeline

dim created this revision.Jun 4 2017, 12:21 PM
Herald added a subscriber: mgorny. · View Herald TranscriptJun 4 2017, 12:22 PM
chapuni added a subscriber: chapuni.Jun 4 2017, 4:02 PM
rnk accepted this revision.Jun 5 2017, 5:53 AM

lgtm, ship it :)

This revision is now accepted and ready to land.Jun 5 2017, 5:53 AM
Closed by commit rL304714: Remove duplicate LLVM_NATIVE_ from llvm's config.h (authored by dim). · Explain WhyJun 5 2017, 6:53 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
include/
llvm/
Config/
21 lines

Diff 101363

include/llvm/Config/config.h.cmake

Show First 20 Lines • Show All 344 Lines • ▼ Show 20 Lines
#cmakedefine01 LLVM_ENABLE_ZLIB #cmakedefine01 LLVM_ENABLE_ZLIB
/* Has gcc/MSVC atomic intrinsics */ /* Has gcc/MSVC atomic intrinsics */
#cmakedefine01 LLVM_HAS_ATOMICS #cmakedefine01 LLVM_HAS_ATOMICS
/* Host triple LLVM will be executed on */ /* Host triple LLVM will be executed on */
#cmakedefine LLVM_HOST_TRIPLE "${LLVM_HOST_TRIPLE}" #cmakedefine LLVM_HOST_TRIPLE "${LLVM_HOST_TRIPLE}"
/* LLVM architecture name for the native architecture, if available */
#cmakedefine LLVM_NATIVE_ARCH ${LLVM_NATIVE_ARCH}
/* LLVM name for the native AsmParser init function, if available */
#cmakedefine LLVM_NATIVE_ASMPARSER LLVMInitialize${LLVM_NATIVE_ARCH}AsmParser
/* LLVM name for the native AsmPrinter init function, if available */
#cmakedefine LLVM_NATIVE_ASMPRINTER LLVMInitialize${LLVM_NATIVE_ARCH}AsmPrinter
/* LLVM name for the native Disassembler init function, if available */
#cmakedefine LLVM_NATIVE_DISASSEMBLER LLVMInitialize${LLVM_NATIVE_ARCH}Disassembler
/* LLVM name for the native Target init function, if available */
#cmakedefine LLVM_NATIVE_TARGET LLVMInitialize${LLVM_NATIVE_ARCH}Target
/* LLVM name for the native TargetInfo init function, if available */
#cmakedefine LLVM_NATIVE_TARGETINFO LLVMInitialize${LLVM_NATIVE_ARCH}TargetInfo
/* LLVM name for the native target MC init function, if available */
#cmakedefine LLVM_NATIVE_TARGETMC LLVMInitialize${LLVM_NATIVE_ARCH}TargetMC
/* Define if this is Unixish platform */ /* Define if this is Unixish platform */
#cmakedefine LLVM_ON_UNIX ${LLVM_ON_UNIX} #cmakedefine LLVM_ON_UNIX ${LLVM_ON_UNIX}
/* Define if this is Win32ish platform */ /* Define if this is Win32ish platform */
#cmakedefine LLVM_ON_WIN32 ${LLVM_ON_WIN32} #cmakedefine LLVM_ON_WIN32 ${LLVM_ON_WIN32}
/* Define if we have the Intel JIT API runtime support library */ /* Define if we have the Intel JIT API runtime support library */
#cmakedefine01 LLVM_USE_INTEL_JITEVENTS #cmakedefine01 LLVM_USE_INTEL_JITEVENTS
▲ Show 20 Lines • Show All 59 Lines • Show Last 20 Lines