Page MenuHomePhabricator

Add AVR to LLVM_ALL_TARGETS
AbandonedPublic

Authored by xiangzhai on May 19 2017, 12:35 AM.

Details

Summary

Hi LLVM developers,

As George mentioned in D32991 :

I tried to run llvm-mc to check which relocations are produced here but got an error: /home/umb/LLVM/llvm-build/bin/llvm-mc: : error: unable to get target for 'avr-unknown-linux', see --version and --triple.

As Rafael suggested: AVR is not in LLVM_ALL_TARGETS. I wonder if we should change it before D32991.

Please review my patch, thanks a lot!

Regards,
Leslie Zhai

Diff Detail

Repository
rL LLVM

Event Timeline

xiangzhai created this revision.May 19 2017, 12:35 AM

I personally wouldn't be comfortable making the backend a non-experimental backend just yet.

There are still a lot of bugs which forbid most complex programs from being compiled. Once it is somewhat more usable, I'd definitely push for making the backend a first-class citizen.

On top of this, when we actually promote the backend to a default target, we would need to remove AVR FROM the LLVM_EXPERIMENTAL_TARGETS_TO_BUILD option

xiangzhai abandoned this revision.Jan 13 2018, 11:28 PM