This is an archive of the discontinued LLVM Phabricator instance.

Differential D33219

Fix executable stack directive on Linux.
ClosedPublic

Authored by manojgupta on May 15 2017, 3:55 PM.

Details

Reviewers
echristo
krytarowski
compnerd
rengolin
Commits
rG2361a394b690: Fix executable stack directive on Linux.
rCRT303131: Fix executable stack directive on Linux.
rL303131: Fix executable stack directive on Linux.
Summary

Use linux to check for Linux and bring back the check for GNU.

Diff Detail

Event Timeline

manojgupta created this revision.May 15 2017, 3:55 PM
Herald added a subscriber: srhines. · View Herald TranscriptMay 15 2017, 3:55 PM
krytarowski requested changes to this revision.May 15 2017, 4:04 PM

The __linux__ check makes __ANDROID__ redundant.

This revision now requires changes to proceed.May 15 2017, 4:04 PM
krytarowski added a subscriber: phosek.May 15 2017, 4:05 PM

@phosek ping for Fuchsia, perhaps needed as well.

echristo edited edge metadata.May 15 2017, 4:07 PM

Probably.

manojgupta retitled this revision from Fix executable stack detection on Linux. to Fix executable stack directive on Linux..May 15 2017, 4:20 PM
manojgupta edited the summary of this revision. (Show Details)
krytarowski accepted this revision.May 15 2017, 4:24 PM
This revision is now accepted and ready to land.May 15 2017, 4:24 PM
manojgupta updated this revision to Diff 99083.May 15 2017, 4:26 PM

Remove check for Android since it is covered by Linux checks.

Harbormaster completed remote builds in B6463: Diff 99083.May 15 2017, 4:26 PM
manojgupta closed this revision.May 15 2017, 4:27 PM

Revision Contents

PathSize
lib/
builtins/
3 lines

Diff 99083

lib/builtins/assembly.h

Show All 38 Lines
#define FILE_LEVEL_DIRECTIVE #define FILE_LEVEL_DIRECTIVE
#if defined(__arm__) #if defined(__arm__)
#define SYMBOL_IS_FUNC(name) .type name,%function #define SYMBOL_IS_FUNC(name) .type name,%function
#else #else
#define SYMBOL_IS_FUNC(name) .type name,@function #define SYMBOL_IS_FUNC(name) .type name,@function
#endif #endif
#define CONST_SECTION .section .rodata #define CONST_SECTION .section .rodata
#if defined(__GNUC__) || defined(__ANDROID__) || defined(__FreeBSD__) #if defined(__GNU__) || defined(__FreeBSD__) || defined(__Fuchsia__) || \
defined(__linux__)
#define NO_EXEC_STACK_DIRECTIVE .section .note.GNU-stack,"",%progbits #define NO_EXEC_STACK_DIRECTIVE .section .note.GNU-stack,"",%progbits
#else #else
#define NO_EXEC_STACK_DIRECTIVE #define NO_EXEC_STACK_DIRECTIVE
#endif #endif
#else // !__APPLE__ && !__ELF__ #else // !__APPLE__ && !__ELF__
#define HIDDEN(name) #define HIDDEN(name)
▲ Show 20 Lines • Show All 114 Lines • Show Last 20 Lines