The vec_xxsldwi and vec_xxpermdi builtins are missing from altivec.h. This has been requested by developers working on libvpx for VP9 support for Google. Define intrinsics to map to the corresponding PowerPC hard instruction (XXSLDWI, and XXPERMDI) directly.
Minor nit, the description doesn't need to have the signatures for the builtins (since this patch does not add any such builtins). Also, ATTRS_o_ai is an implementation detail and not part of the signatures required - on an unrelated note, it will probably not even be used in the final implementation.
These don't need to be here. The instructions are not P9 specific. All targets with VSX have them.
|1 ↗||(On Diff #97539)|
No need to restrict this to P9.
A quick question:
I think the clang side of these can lower into generic vector operations rather than intrinsics right? Which would mean that we don't need intrinsics defined for these?
These builtins (vec_permdi, vec_xlsdwi) can lower into generic vector operations on the clang side only rather than intrinsics in the llvm part and bulitins in the clang part, abandon this patch and re-implement another one in just clang portion.