This is an archive of the discontinued LLVM Phabricator instance.

[ARM] Rename HW div feature to HW div Thumb. NFCI.
ClosedPublic

Authored by rovka on Apr 18 2017, 3:30 AM.

Details

Summary

The hardware div feature refers only to Thumb, but because of its name
it is tempting to use it to check for hardware division in general, which
may cause problems in ARM mode. See https://reviews.llvm.org/D32005.

This patch adds "Thumb" to its name, to make its scope clear. One
notable place where I haven't made the change is in the feature flag
(used with -mattr), which is still hwdiv. Changing it would also require
changes in a lot of tests, including clang tests, and it doesn't seem
like it's worth the effort.

Diff Detail

Event Timeline

rovka created this revision.Apr 18 2017, 3:30 AM
compnerd accepted this revision.Apr 19 2017, 6:18 PM

Thanks for doing this cleanup!

This revision is now accepted and ready to land.Apr 19 2017, 6:18 PM
This revision was automatically updated to reflect the committed changes.