This is an archive of the discontinued LLVM Phabricator instance.

[globalisel][tablegen] Report more detail in some SelectionDAG import failures. NFC
ClosedPublic

Authored by dsanders on Mar 24 2017, 5:03 AM.

Event Timeline

dsanders created this revision.Mar 24 2017, 5:03 AM
ab accepted this revision.Mar 27 2017, 11:02 AM

A couple minor nits, but LGTM.

utils/TableGen/GlobalISelEmitter.cpp
1334–1348

Can you also outline this one into some sort of "explainOperator"?

1336–1345

All of these cases seem obvious from the name; maybe print them all as '(<operator>)' ?

1628

Have isTrivialOperatorNode return an Error instead? That lets you do something like:

if (auto Err = checkTrivialOperatorNode(Dst))

return failedImport("Dst pattern root isn't a trivial operator (" + toString(Err) + ")");
1642

Is llvm:: needed?

This revision is now accepted and ready to land.Mar 27 2017, 11:02 AM
dsanders updated this revision to Diff 94348.Apr 6 2017, 4:25 AM
dsanders marked 2 inline comments as done.

Update to account for nits

dsanders closed this revision.Apr 13 2017, 2:58 AM