Page MenuHomePhabricator

[PPC] Add generated tests for all atomic operations
ClosedPublic

Authored by timshen on Mar 23 2017, 7:34 AM.

Details

Summary

Add tests for all atomic operations for powerpc64le, so that all changes can be easily examined.

Diff Detail

Repository
rL LLVM

Event Timeline

timshen created this revision.Mar 23 2017, 7:34 AM
timshen updated this revision to Diff 92794.Mar 23 2017, 7:40 AM

Remove blank line in the end.

hfinkel accepted this revision.Mar 23 2017, 7:45 AM

Please strip comments like this "# =>This Inner Loop Header: Depth=1" from the check lines. We should be able to change those kinds of comments without affecting the tests. Otherwise, LGTM.

This revision is now accepted and ready to land.Mar 23 2017, 7:45 AM
timshen updated this revision to Diff 92815.Mar 23 2017, 9:07 AM

Remove loop comments.

Done.

I also tried to remove basic block comments. It turns out to be hard, because empty CHECK lines are not allowed. So I gave up. :P

This revision was automatically updated to reflect the committed changes.

Done.

I also tried to remove basic block comments. It turns out to be hard, because empty CHECK lines are not allowed. So I gave up. :P

The way to do that is to give the basic blocks a name:

define void test0() {
entry:
  ...
  ret void
}

This will say "entry:" rather than a comment. I much prefer this, especially when generating check lines with the script.

This will say "entry:" rather than a comment. I much prefer this, especially when generating check lines with the script.

I didn't get "entry:", but rather "# BB#0: # %entry". I used a "Optimized build with assertions" llc.