This is an archive of the discontinued LLVM Phabricator instance.

Differential D30413

ARM: Set default CPU for OpenBSD/arm to Cortex-A8
AbandonedPublic

Authored by brad on Feb 27 2017, 9:21 AM.

Download Raw Diff

Details

Reviewers

rengolin

Summary

Set default CPU for OpenBSD/arm to Cortex-A8

Diff Detail

Repository: rL LLVM

Event Timeline

brad created this revision.Feb 27 2017, 9:21 AM

Herald added subscribers: rengolin, aemerson. · View Herald TranscriptFeb 27 2017, 9:21 AM

Tests?

In D30413#687461, @rengolin wrote:

Tests?

I posted the diff here as I wasn't sure what to use as a test (as opposed to from Clang's perspective).

You probably want unittests/ADT/TripleTest.cpp. A good way to find this out yourself is to "git blame" the file you're modifying and look at what tests were added for similar bits. A refactoring in this case, but it's still pretty evident from the diff.

Add a test

I'm not sure why OpenBSD needs "arm" to default to cortex-A8, but assuming that's the correct behaviour, LGTM. It's not like others don't do that as well. :)

This revision is now accepted and ready to land.Feb 27 2017, 2:54 PM

brad abandoned this revision.Jun 18 2022, 5:04 PM

Herald added a project: Restricted Project. · View Herald TranscriptJun 18 2022, 5:04 PM

Herald added subscribers: kristof.beyls, krytarowski. · View Herald Transcript

Revision Contents

Path

Size

lib/

Support/

Triple.cpp

1 line

Diff 89895

lib/Support/Triple.cpp

Context not available.
	return "strongarm";	return "strongarm";
	}	}
	case llvm::Triple::NaCl:	case llvm::Triple::NaCl:
		case llvm::Triple::OpenBSD:
	return "cortex-a8";	return "cortex-a8";
	default:	default:
	switch (getEnvironment()) {	switch (getEnvironment()) {
Context not available.