This is an archive of the discontinued LLVM Phabricator instance.

ARM: Set default CPU for OpenBSD/arm to Cortex-A8
AbandonedPublic

Authored by brad on Feb 27 2017, 9:21 AM.

Details

Reviewers
rengolin
Summary

Set default CPU for OpenBSD/arm to Cortex-A8

Diff Detail

Event Timeline

brad created this revision.Feb 27 2017, 9:21 AM
brad added a comment.Feb 27 2017, 11:30 AM

Tests?

I posted the diff here as I wasn't sure what to use as a test (as opposed to from Clang's perspective).

You probably want unittests/ADT/TripleTest.cpp. A good way to find this out yourself is to "git blame" the file you're modifying and look at what tests were added for similar bits. A refactoring in this case, but it's still pretty evident from the diff.

brad updated this revision to Diff 89933.Feb 27 2017, 1:58 PM

Add a test

rengolin accepted this revision.Feb 27 2017, 2:54 PM

I'm not sure why OpenBSD needs "arm" to default to cortex-A8, but assuming that's the correct behaviour, LGTM. It's not like others don't do that as well. :)

This revision is now accepted and ready to land.Feb 27 2017, 2:54 PM
brad abandoned this revision.Jun 18 2022, 5:04 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 18 2022, 5:04 PM