Details
- Reviewers
- None
Diff Detail
- Build Status
Buildable 3853 Build 3853: arc lint + arc unit
Event Timeline
But I use this file as a benchmark of clang's compilation speed! If you change it, my years of carefully-curated benchmark results will be rendered useless. Can you add an option to do it the old way? Please don't break my workflow.
</troll>
Possibly worth structuring the new files as copies of the original file, so that we retain history in svn. Although it's not going to help git at all, so maybe that doesn't matter?
Will do... I think git-svn will do the right thing on dcommit, so.... that's something.
OK, thanks for the cleanup! I hate these infinitely long files :)
(I wouldn't bother with the svn attributes, but if it is trivial *shrug*)
Will do... I think git-svn will do the right thing on dcommit, so.... that's something.
I suspect it will iff git recognizes the change as a file copy. Which depends on the -M and -C flags passed to git diff by git-svn.
I'll take this as volunteering to review. :-)
(Although comments ahead of time are welcome, too... I just don't want people to think this is the expected end state.)
Ahah! Sure :)
That said I rather review the patch with cfe-commits CC'ed, to have everything happening on the mailing-list and not in private, seems more friendly with the rest of the community.