This is an archive of the discontinued LLVM Phabricator instance.

First cut at moving driver tools into their own files.
AbandonedPublic

Authored by dlj on Feb 9 2017, 4:40 PM.

Details

Reviewers
None

Event Timeline

dlj created this revision.Feb 9 2017, 4:40 PM
tra added a subscriber: tra.Feb 9 2017, 4:42 PM
jlebar added a subscriber: jlebar.Feb 9 2017, 4:45 PM

But I use this file as a benchmark of clang's compilation speed! If you change it, my years of carefully-curated benchmark results will be rendered useless. Can you add an option to do it the old way? Please don't break my workflow.

</troll>

Possibly worth structuring the new files as copies of the original file, so that we retain history in svn. Although it's not going to help git at all, so maybe that doesn't matter?

cfg-commits not subscribed apparently? Is this supposed to be up for review?

dlj added a comment.Feb 9 2017, 5:20 PM

cfg-commits not subscribed apparently? Is this supposed to be up for review?

Nope... just a first cut to show other folks. Sorry for the noise.

dlj added a comment.Feb 9 2017, 5:21 PM

Possibly worth structuring the new files as copies of the original file, so that we retain history in svn. Although it's not going to help git at all, so maybe that doesn't matter?

Will do... I think git-svn will do the right thing on dcommit, so.... that's something.

OK, thanks for the cleanup! I hate these infinitely long files :)
(I wouldn't bother with the svn attributes, but if it is trivial *shrug*)

jlebar added a comment.Feb 9 2017, 5:23 PM

Will do... I think git-svn will do the right thing on dcommit, so.... that's something.

I suspect it will iff git recognizes the change as a file copy. Which depends on the -M and -C flags passed to git diff by git-svn.

dlj added a subscriber: mehdi_amini.Feb 9 2017, 5:51 PM

OK, thanks for the cleanup! I hate these infinitely long files :)
(I wouldn't bother with the svn attributes, but if it is trivial *shrug*)

I'll take this as volunteering to review. :-)

(Although comments ahead of time are welcome, too... I just don't want people to think this is the expected end state.)

In D29799#673004, @dlj wrote:

OK, thanks for the cleanup! I hate these infinitely long files :)
(I wouldn't bother with the svn attributes, but if it is trivial *shrug*)

I'll take this as volunteering to review. :-)

Ahah! Sure :)

That said I rather review the patch with cfe-commits CC'ed, to have everything happening on the mailing-list and not in private, seems more friendly with the rest of the community.

dlj abandoned this revision.Feb 25 2017, 5:42 PM
lib/Driver/Tools.h