This is an archive of the discontinued LLVM Phabricator instance.

[scudo] Enabling AArch64 support for Scudo
ClosedPublic

Authored by cryptoad on Jan 20 2017, 10:57 AM.

Details

Summary

Adding ARM64 as a supported architecture for Scudo.
The random shuffle is not yet supported for SizeClassAllocator32, which is used
by the AArch64 allocator, so disable the associated test for now.

Event Timeline

cryptoad created this revision.Jan 20 2017, 10:57 AM
rengolin edited edge metadata.Jan 24 2017, 2:55 AM

I'm assuming this will enable testing on all buildbots. Did you run "check-all" on an AArch64 machine?

check-scudo was successfully tested on an aarch64 board.

pi@localhost:~/llvm-build> uname -a
Linux raspberry 4.4.39-5-default #1 SMP Fri Jan 6 06:11:51 UTC 2017 (170ddd6) aarch64 aarch64 aarch64 GNU/Linux
pi@localhost:~/llvm-build> ninja check-scudo
[1/2] Running the Scudo Hardened Allocator tests
-- Testing: 15 tests, 4 threads --
Testing: 0 .. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90.. 
Testing Time: 5.32s
  Expected Passes    : 14
  Unsupported Tests  : 1
rengolin accepted this revision.Jan 25 2017, 8:44 AM

check-scudo was successfully tested on an aarch64 board.

Thanks! I think Pi3's kernel is in AArch32 mode, but that is enough to get it in and see if the bots complaint about something.

LGTM, thanks!

This revision is now accepted and ready to land.Jan 25 2017, 8:44 AM
cryptoad closed this revision.Jan 25 2017, 8:46 AM

Thank you Renato!