This is an archive of the discontinued LLVM Phabricator instance.

[AArch64] Rename 'no-quad-ldst-pairs' to 'slow-paired-128'
ClosedPublic

Authored by evandro on Jan 19 2017, 1:55 PM.

Details

Summary

In order to follow the pattern of the existing slow-misaligned-128store option, rename the option no-quad-ldst-pairs to slow-paired-128.

Also, OK to backport to 4.0?

Diff Detail

Repository
rL LLVM

Event Timeline

evandro created this revision.Jan 19 2017, 1:55 PM
rengolin edited edge metadata.

I don't have a strong opinion either way. Adding more people to get more opinions.

I don't have a strong opinion either way. Adding more people to get more opinions.

Same here; no strong opinion either way.

evandro updated this revision to Diff 85028.Jan 19 2017, 2:09 PM
evandro retitled this revision from [AArch64] Rename 'no-quad-ldst-pairs' to 'slow-pair-128' to [AArch64] Rename 'no-quad-ldst-pairs' to 'slow-paired-128'.
evandro edited the summary of this revision. (Show Details)
rengolin accepted this revision.Jan 24 2017, 2:35 AM

Right, approving this for trunk, as it's harmless and generally seen as neutral. I'll let the AArch64 maintainers decide if it's a good idea to backport to 4.0.

Evandro, after commit, open a bug in bugzilla, make it block PR31622 and copy the usual suspects + Hans asking to backport.

This revision is now accepted and ready to land.Jan 24 2017, 2:35 AM

Created PR31740 to track backporting this patch to 4.0.