This set of patches adds support for Cavium ThunderX ARM64 processors:
- ThunderX
- ThunderX T81
- ThunderX T83
- ThunderX T88
Paths
| Differential D28891
add support for Cavium ThunderX ARM64 processors ClosedPublic Authored by steleman on Jan 18 2017, 10:05 PM.
Details Summary This set of patches adds support for Cavium ThunderX ARM64 processors:
Diff Detail
Event TimelineComment Actions Few inline comments. I'm adding a few people to review plus copying llvm-commits. Next time, remember that if you don't do that, people don't see it. :) cheers,
Comment Actions Hi: A few points you may want to consider :
Best Regards Comment Actions
Thank you very much for the comments - Renato and Javed. I will add test cases, review the latencies and re-submit with corrections. MatzeB added inline comments.
Comment Actions The feature bits set match my (limited) understanding of the various ThunderX variants, and their implementation in GCC. From that perspective this patch looks good to me. I don't have any opinion on the pipeline model (I don't have access to a datasheet to check against), nor on how idiomatic this patch would be for LLVM (I'm not familiar with the code base). Comment Actions Fixes and corrections as per review comments. Comment Actions Hi, can you also please add the relevant tests to unittests/Support/TargetParserTest.cpp? It should be pretty obvious from the context. Looks good otherwise. Comment Actions
Yes I certainly can. Please stay tuned. Comment Actions
This revision is now accepted and ready to land.Feb 9 2017, 1:32 PM
Comment Actions
Thanks, still good to go. Closed by commit rL295475: [AArch64] Add Cavium ThunderX support (authored by joel_k_jones). · Explain WhyFeb 17 2017, 10:46 AM This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 87865 include/llvm/Support/AArch64TargetParser.def
lib/Support/TargetParser.cpplib/Target/AArch64/AArch64.td
lib/Target/AArch64/AArch64SchedThunderX.td
lib/Target/AArch64/AArch64Subtarget.h
lib/Target/AArch64/AArch64Subtarget.cpp
test/MC/AArch64/armv8.1a-lse.s
unittests/Support/TargetParserTest.cpp
|
Please, add unit test for this and the new cores.