This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU] Add exec copy to LiveIntervals in SILowerControlFlow::emitElse
ClosedPublic

Authored by rampitec on Jan 18 2017, 4:19 PM.

Details

Diff Detail

Repository
rL LLVM

Event Timeline

rampitec created this revision.Jan 18 2017, 4:19 PM
arsenm edited edge metadata.Jan 19 2017, 10:36 AM

I would expect this to fail the verifier. Do you have a test where this failed it?

arsenm accepted this revision.Jan 19 2017, 10:36 AM

LGTM but a test would be nice

This revision is now accepted and ready to land.Jan 19 2017, 10:36 AM

I would expect this to fail the verifier. Do you have a test where this failed it?

No, I have not seen any failures. As I said I'm not aware of any problems because of this.

This revision was automatically updated to reflect the committed changes.

I would expect this to fail the verifier. Do you have a test where this failed it?

No, I have not seen any failures. As I said I'm not aware of any problems because of this.

Oh, I forgot I moved this to the point in the pipeline where the verifier is disabled