This is an archive of the discontinued LLVM Phabricator instance.

[Assembler] Fix crash when assembling .quad for AArch32.
ClosedPublic

Authored by sanwou01 on Jan 18 2017, 3:09 AM.

Details

Summary

A 64-bit relocation does not exist in 32-bit ARMELF. Report an error
instead of crashing.

Fix PR23870.

Diff Detail

Repository
rL LLVM

Event Timeline

sanwou01 created this revision.Jan 18 2017, 3:09 AM
rengolin accepted this revision.Jan 18 2017, 3:29 AM

Always good to move crashes into error messages. LGTM. Thanks!

This revision is now accepted and ready to land.Jan 18 2017, 3:29 AM
sanwou01 retitled this revision from Fix crash when assembling .quad for AArch32. to [Assembler] Fix crash when assembling .quad for AArch32..Jan 18 2017, 3:44 AM
sanwou01 edited the summary of this revision. (Show Details)
sanwou01 set the repository for this revision to rL LLVM.
sanwou01 added a subscriber: llvm-commits.

Thanks @rengolin.

I do not have commit access; could someone commit on my behalf?

This revision was automatically updated to reflect the committed changes.

Thanks @rengolin.

I do not have commit access; could someone commit on my behalf?

Done. I also updated the PR accordingly.