Falkor only partially implements the ARMv8.1a extensions, so this patch refactors the support for the SQRDML[A|S]H instruction into a separate feature.
Chad
Paths
| Differential D28681
[AArch64] Enable Rounding Double Multiply Add/Subtract instructions on Falkor. ClosedPublic Authored by mcrosier on Jan 13 2017, 8:14 AM.
Details Summary Falkor only partially implements the ARMv8.1a extensions, so this patch refactors the support for the SQRDML[A|S]H instruction into a separate feature. Chad
Diff Detail Event Timelineab edited edge metadata. Comment ActionsLGTM
This revision is now accepted and ready to land.Jan 13 2017, 11:10 AM
Closed by commit rL292142: [AArch64] Falkor supports Rounding Double Multiply Add/Subtract instructions. (authored by mcrosier). · Explain WhyJan 16 2017, 8:39 AM This revision was automatically updated to reflect the committed changes. Comment Actions I settled on adding a new RUN line, but used the CHECK-V81a prefix. I believe this was in the same vein as your original suggestion, Ahmed, but minimized code changes while still providing the necessary testing coverage.
Revision Contents
Diff 84309 lib/Target/AArch64/AArch64.td
lib/Target/AArch64/AArch64InstrFormats.td
lib/Target/AArch64/AArch64InstrInfo.td
lib/Target/AArch64/AArch64Subtarget.h
test/CodeGen/AArch64/arm64-neon-v8.1a.ll
|
Maybe add --check-prefix=CHECK-RDM to the v8.1a line, and remove the rdm CHECK-V81a lines?