To import a type identifier we read the summary and create external
references to the symbols defined when exporting.
Details
Diff Detail
- Repository
- rL LLVM
Event Timeline
llvm/lib/Transforms/IPO/LowerTypeTests.cpp | ||
---|---|---|
735 ↗ | (On Diff #83909) | This function does not import SizeM1BitWidth. |
746 ↗ | (On Diff #83909) | I don't get this condition. Why would this variable exist and be non-hidden? |
758 ↗ | (On Diff #83909) | should this say 0ull, ~0ull ? |
llvm/lib/Transforms/IPO/LowerTypeTests.cpp | ||
---|---|---|
735 ↗ | (On Diff #83909) | No, we don't need it. Removed in r292647. |
746 ↗ | (On Diff #83909) | If getOrInsertGlobal created the global, it would have default visibility. Added a comment. |
758 ↗ | (On Diff #83909) | "~0ull, ~0ull" means the full set, whereas "0ull, ~0ull" means the full set except for the value ~0ull. From http://llvm.org/docs/LangRef.html#range-metadata : "The pair a,b represents the range [a,b).". See also http://llvm-cs.pcc.me.uk/lib/IR/ConstantRange.cpp#237 Added a comment. |
llvm/lib/Transforms/IPO/LowerTypeTests.cpp | ||
---|---|---|
758 ↗ | (On Diff #83909) | From http://llvm.org/docs/LangRef.html#range-metadata, The range should not represent the full or empty set. That is, a!=b. Does the documentation need to be updated? |
llvm/lib/Transforms/IPO/LowerTypeTests.cpp | ||
---|---|---|
758 ↗ | (On Diff #83909) | The doc for range is correct, but the one for absolute_symbol needs to be corrected. I'll do that. |