Page MenuHomePhabricator

LowerTypeTests: Represent the memory region size with the constant size-1.
ClosedPublic

Authored by pcc on Jan 6 2017, 4:28 PM.

Details

Summary

This means that we can use a shorter instruction sequence in the case where
the size is a power of two and on the boundary between two representations.

Diff Detail

Repository
rL LLVM

Event Timeline

pcc updated this revision to Diff 83460.Jan 6 2017, 4:28 PM
pcc retitled this revision from to LowerTypeTests: Represent the memory region size with the constant size-1..
pcc updated this object.
pcc added a reviewer: eugenis.
pcc added a subscriber: llvm-commits.
eugenis added inline comments.Jan 10 2017, 5:21 PM
llvm/lib/Transforms/IPO/LowerTypeTests.cpp
686 ↗(On Diff #83460)

I don;t get it. Why do we switch to a 32-bit check when BitSize == 129?

eugenis accepted this revision.Jan 10 2017, 6:26 PM
eugenis edited edge metadata.

LGTM

This revision is now accepted and ready to land.Jan 10 2017, 6:26 PM
pcc added a comment.Jan 10 2017, 6:27 PM

I'll land this once we've figured out the issue behind D28532.

This revision was automatically updated to reflect the committed changes.