Details
Details
Diff Detail
Diff Detail
- Repository
- rL LLVM
Event Timeline
Comment Actions
The test are a bit obscure for someone who does not know well how the type-tests works.
If @eugenis can review this, that'd be great, otherwise I'll try to "page this in" later this week and get it done.
llvm/lib/Transforms/IPO/LowerTypeTests.cpp | ||
---|---|---|
257 ↗ | (On Diff #83474) | May not be straightforward to know what it means to "be exported" when reading this code. |
697 ↗ | (On Diff #83474) | One line comment before this function? |
llvm/test/Transforms/LowerTypeTests/Inputs/use-typeid1-typeid2.yaml | ||
---|---|---|
4 ↗ | (On Diff #84878) | Are these GUIDs for some global value? Could you add a comment please? |
llvm/test/Transforms/LowerTypeTests/Inputs/use-typeid1-typeid2.yaml | ||
---|---|---|
4 ↗ | (On Diff #84878) | "typeid1" and "typeid2". I'll add a comment. |