Page MenuHomePhabricator

[OpenMP] Code cleanup for NVPTX OpenMP codegen
ClosedPublic

Authored by arpith-jacob on Dec 27 2016, 8:53 AM.

Details

Summary

This patch cleans up private methods for NVPTX OpenMP codegen. It converts private members to static functions to follow the coding style of CGOpenMPRuntime.cpp and declutter the header file.

Diff Detail

Event Timeline

arpith-jacob retitled this revision from to [OpenMP] Code cleanup for NVPTX OpenMP codegen.
arpith-jacob updated this object.
arpith-jacob added a subscriber: cfe-commits.
ABataev accepted this revision.Dec 28 2016, 2:50 AM
ABataev edited edge metadata.

Function names must start with a lower case letter. LG for other changes

This revision is now accepted and ready to land.Dec 28 2016, 2:50 AM
jlebar added a subscriber: jlebar.Dec 28 2016, 10:33 AM
jlebar added inline comments.
lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp
31
arpith-jacob edited edge metadata.

Addressed comments in review to start function names with a lowercase letter and to fix the enum type name along with the enumerator name.

arpith-jacob marked an inline comment as done.Dec 28 2016, 2:21 PM
This revision was automatically updated to reflect the committed changes.