This is an archive of the discontinued LLVM Phabricator instance.

Differential D27908

[lit] Fix shtest-output-printing test on Windows
AbandonedPublic

Authored by modocache on Dec 18 2016, 5:32 PM.

Details

Reviewers
echristo
beanz
• ddunbar
delcypher
Summary

When run on Windows, the shtest-output-printing.py test fails because it
searches for Unix path separator '/', as opposed to Windows separator '\'.
Match both so that the test passes on all platforms.

Diff Detail

Event Timeline

modocache updated this revision to Diff 81903.Dec 18 2016, 5:32 PM
modocache retitled this revision from to [lit] Fix shtest-output-printing test on Windows.
modocache updated this object.
modocache added reviewers: echristo, beanz, • ddunbar, delcypher.
modocache added a subscriber: llvm-commits.
Herald added a subscriber: mehdi_amini. · View Herald TranscriptDec 18 2016, 5:32 PM
modocache mentioned this in D27701: [lit] Fix discovery test on Windows.Dec 18 2016, 7:38 PM
modocache abandoned this revision.Jul 27 2017, 7:51 AM
modocache added a subscriber: rnk.

The equivalent of this change was committed by @rnk in rL309198.

Revision Contents

PathSize
utils/
lit/
tests/
2 lines

Diff 81903

utils/lit/tests/shtest-output-printing.py

Show All 16 Lines
# CHECK: Command Output # CHECK: Command Output
# CHECK-NEXT: -- # CHECK-NEXT: --
# CHECK-NEXT: $ "true" # CHECK-NEXT: $ "true"
# CHECK-NEXT: $ "echo" "hi" # CHECK-NEXT: $ "echo" "hi"
# CHECK-NEXT: # command output: # CHECK-NEXT: # command output:
# CHECK-NEXT: hi # CHECK-NEXT: hi
# #
# CHECK: $ "wc" "missing-file" # CHECK: $ "wc" "missing-file"
# CHECK-NEXT: # redirected output from '{{.*}}/basic.txt.tmp.out': # CHECK-NEXT: # redirected output from '{{.*[/\\]}}basic.txt.tmp.out':
# CHECK-NEXT: missing-file{{.*}} No such file or directory # CHECK-NEXT: missing-file{{.*}} No such file or directory
# CHECK: note: command had no output on stdout or stderr # CHECK: note: command had no output on stdout or stderr
# CHECK-NEXT: error: command failed with exit status: 1 # CHECK-NEXT: error: command failed with exit status: 1