This is an archive of the discontinued LLVM Phabricator instance.

[OpenMP] Sema and parsing for 'teams distribute parallel for simd' pragma
ClosedPublic

Authored by kkwli0 on Nov 23 2016, 8:36 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

kkwli0 updated this revision to Diff 79185.Nov 23 2016, 8:36 PM
kkwli0 retitled this revision from to [OpenMP] Sema and parsing for 'teams distribute parallel for simd' pragma.
kkwli0 updated this object.
kkwli0 added a subscriber: cfe-commits.
kkwli0 updated this revision to Diff 79257.Nov 24 2016, 2:14 PM

Fixed a typo and re-format accordingly.

ABataev added inline comments.Nov 25 2016, 9:01 AM
lib/Basic/OpenMPKinds.cpp
685 ↗(On Diff #79257)

I think this new directive must be considered as a worksharing directive also.

lib/Parse/ParseOpenMP.cpp
21 ↗(On Diff #79257)

Restore this line

test/OpenMP/nesting_of_regions.cpp
3326 ↗(On Diff #79257)

what about teams distribute parallel for simd inside the ordered directive? Why this one is removed?

kkwli0 marked 2 inline comments as done.Nov 29 2016, 6:16 PM
kkwli0 added inline comments.
test/OpenMP/nesting_of_regions.cpp
3326 ↗(On Diff #79257)

This is a typo (likely due to copy and paste error), it should be atomic as this section is to test constructs nested inside an atomic construct. The testing of constructs nested inside an ordered construct is in line 2910-3149.

kkwli0 updated this revision to Diff 79696.Nov 29 2016, 7:16 PM
  • fixes based on comments in the review
  • added if clause test case
ABataev accepted this revision.Nov 30 2016, 1:59 AM
ABataev edited edge metadata.

LG

This revision is now accepted and ready to land.Nov 30 2016, 1:59 AM
This revision was automatically updated to reflect the committed changes.