This is an archive of the discontinued LLVM Phabricator instance.

GlobalISel: Fix unconditional fallback with global isel abort is disabled
ClosedPublic

Authored by tstellarAMD on Nov 16 2016, 12:51 PM.

Event Timeline

tstellarAMD retitled this revision from to GlobalISel: Fix unconditional fallback with global isel abort is disabled.
tstellarAMD updated this object.
tstellarAMD added a subscriber: llvm-commits.
t.p.northover edited edge metadata.Nov 16 2016, 1:03 PM

Should that condition even be there? It seems like a selector may well want to add extra blocks and that's probably one of the benefits of GlobalISel.

Should that condition even be there? It seems like a selector may well want to add extra blocks and that's probably one of the benefits of GlobalISel.

There assertion right afterwards says that inserting blocks is not supported, so if that's true then I think we need to keep it.

ab accepted this revision.Nov 16 2016, 1:28 PM
ab edited edge metadata.

I'm fine with removing the restriction, but we need to decide whether to select the new block. If so, the MF iteration will need to be fixed. If not, let's make it explicit and verify it.

For now, the patch LGTM.

This revision is now accepted and ready to land.Nov 16 2016, 1:28 PM
qcolombet edited edge metadata.Nov 16 2016, 3:26 PM

I'm fine with removing the restriction, but we need to decide whether to select the new block. If so, the MF iteration will need to be fixed. If not, let's make it explicit and verify it.

It could be a work list and the target decide to push the new block into it or not.

I would rather remove this limitation but given we don't have a use case/test case, for now let us keep it.

This revision was automatically updated to reflect the committed changes.