This is an archive of the discontinued LLVM Phabricator instance.

[AArch64] Add support for Qualcomm's Falkor CPU
ClosedPublic

Authored by mcrosier on Nov 15 2016, 7:56 AM.

Details

Summary

This patch add the most basic support for Qualcomm's Falkor CPU. Additional features, tuning, scheduling model, etc. to follow at a later time.

Chad

Diff Detail

Event Timeline

mcrosier updated this revision to Diff 78001.Nov 15 2016, 7:56 AM
mcrosier retitled this revision from to [AArch64] Add support for Qualcomm's Falkor CPU.
mcrosier updated this object.
mcrosier added reviewers: rengolin, t.p.northover.
mcrosier added subscribers: llvm-commits, echristo.
echristo accepted this revision.Nov 15 2016, 11:33 AM
echristo added a reviewer: echristo.

LGTM.

-eric

This revision is now accepted and ready to land.Nov 15 2016, 11:33 AM
rengolin accepted this revision.Nov 15 2016, 11:48 AM
rengolin edited edge metadata.
rengolin added inline comments.
lib/Target/AArch64/AArch64Subtarget.cpp
72

nit: move this below with the empty others...

MatzeB accepted this revision.Nov 15 2016, 12:05 PM
MatzeB added a reviewer: MatzeB.
MatzeB added a subscriber: MatzeB.

LGTM

unittests/Support/TargetParserTest.cpp
545–548

Maybe reformat this list to have 1 name per line. This makes it friendlier for merging/cherry picking. (I also like the fact that I can easily sort such a list of names alphabetically in my editor).

mcrosier marked an inline comment as done.Nov 15 2016, 1:29 PM
mcrosier added inline comments.
unittests/Support/TargetParserTest.cpp
545–548

Sure. Done in r287031.

mcrosier marked 2 inline comments as done.Nov 15 2016, 1:31 PM
mcrosier added inline comments.
lib/Target/AArch64/AArch64Subtarget.cpp
72

Will do. Thanks, Renato.

This revision was automatically updated to reflect the committed changes.
mcrosier marked an inline comment as done.