This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU/GCN: Exit early in hazard recognizer if there is no vreg argument
ClosedPublic

Authored by jvesely on Nov 14 2016, 1:27 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

jvesely updated this revision to Diff 77874.Nov 14 2016, 1:27 PM
jvesely retitled this revision from to AMDGPU/GCN: Exit early in hazard recognizer if there is no vreg argument.
jvesely updated this object.
jvesely added reviewers: tstellarAMD, arsenm.
jvesely set the repository for this revision to rL LLVM.
jvesely added a subscriber: llvm-commits.
tstellarAMD accepted this revision.Nov 14 2016, 3:46 PM
tstellarAMD edited edge metadata.

LGTM.

This revision is now accepted and ready to land.Nov 14 2016, 3:46 PM
arsenm added inline comments.Nov 14 2016, 4:04 PM
lib/Target/AMDGPU/GCNHazardRecognizer.cpp
399–403

Could you invert this so it's an if (== -1) return -1

jvesely updated this revision to Diff 77921.Nov 14 2016, 4:52 PM
jvesely edited edge metadata.

cleanup

jvesely marked an inline comment as done.Nov 14 2016, 4:53 PM
arsenm accepted this revision.Nov 14 2016, 4:54 PM
arsenm edited edge metadata.

LGTM

jvesely updated this revision to Diff 77932.Nov 14 2016, 6:05 PM
jvesely edited edge metadata.

v2: only checks for M?BUF instructions.

fixes regression in inserted-wait-states.mir

jvesely requested a review of this revision.Nov 15 2016, 11:13 AM
jvesely edited edge metadata.
arsenm accepted this revision.Nov 15 2016, 12:04 PM
arsenm edited edge metadata.

LGTM

This revision is now accepted and ready to land.Nov 15 2016, 12:04 PM
This revision was automatically updated to reflect the committed changes.