This is an archive of the discontinued LLVM Phabricator instance.

[CodeView] Hook CodeViewRecordIO up for reading and writing symbols
ClosedPublic

Authored by zturner on Nov 8 2016, 3:10 PM.

Details

Summary

This is the final patch to get CodeView records reading and writing using the same codepath. It does for symbol records what the first two patches did for type records.

Diff Detail

Event Timeline

zturner updated this revision to Diff 77273.Nov 8 2016, 3:10 PM
zturner retitled this revision from to [CodeView] Hook CodeViewRecordIO up for reading and writing symbols.
zturner updated this object.
zturner added reviewers: rnk, inglorion, amccarth.
zturner added a subscriber: llvm-commits.
amccarth accepted this revision.Nov 8 2016, 4:47 PM
amccarth edited edge metadata.

LGTM

tools/llvm-pdbdump/YamlSymbolDumper.cpp
49

These specializations are all so similar, it's a shame they have to be written out by hand.

This revision is now accepted and ready to land.Nov 8 2016, 4:47 PM
This revision was automatically updated to reflect the committed changes.