This is an archive of the discontinued LLVM Phabricator instance.

Differential D25899

[libunwind] Add support for Fuchsia
ClosedPublic

Authored by phosek on Oct 22 2016, 6:34 PM.

Details

Reviewers
emaste
compnerd
jroelofs
rmaprath
Commits
rG93d28f35078a: [libunwind] Add support for Fuchsia
rUNW284951: [libunwind] Add support for Fuchsia
rL284951: [libunwind] Add support for Fuchsia
Summary

Fuchsia is a new operating system which uses libunwind as unwinder.

Diff Detail

Repository
rL LLVM

Event Timeline

phosek updated this revision to Diff 75539.Oct 22 2016, 6:34 PM
phosek retitled this revision from to [libunwind] Add support for Fuchsia.
phosek updated this object.
phosek added reviewers: compnerd, rmaprath, emaste.
phosek set the repository for this revision to rL LLVM.
phosek added a subscriber: llvm-commits.
Herald added subscribers: srhines, danalbert, tberghammer. · View Herald TranscriptOct 22 2016, 6:34 PM
rmaprath added a reviewer: jroelofs.Oct 23 2016, 12:54 AM
rmaprath edited edge metadata.

This looks fine to me. I'll let either @compnerd or @jroelofs approve.

Cheers,

compnerd accepted this revision.Oct 23 2016, 7:07 AM
compnerd edited edge metadata.

Not sure why you added it to the middle, but that is all the same. They aren't in alphabetical order so the middle insertion is slightly harder to see. LGTM.

This revision is now accepted and ready to land.Oct 23 2016, 7:07 AM
Closed by commit rL284951: [libunwind] Add support for Fuchsia (authored by phosek). · Explain WhyOct 23 2016, 2:58 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
libunwind/
trunk/
src/
4 lines
3 lines

Diff 75555

libunwind/trunk/src/AddressSpace.hpp

Show First 20 Lines • Show All 55 Lines • ▼ Show 20 Linesstruct EHTEntry {
uint32_t functionOffset; uint32_t functionOffset;
uint32_t unwindOpcodes; uint32_t unwindOpcodes;
}; };
extern EHTEntry __exidx_start; extern EHTEntry __exidx_start;
extern EHTEntry __exidx_end; extern EHTEntry __exidx_end;
#endif // !defined(_LIBUNWIND_IS_BAREMETAL) #endif // !defined(_LIBUNWIND_IS_BAREMETAL)
#endif // _LIBUNWIND_ARM_EHABI #endif // _LIBUNWIND_ARM_EHABI
#if defined(__CloudABI__) || defined(__FreeBSD__) || defined(__linux__) || \ #if defined(__CloudABI__) || defined(__FreeBSD__) || defined(__Fuchsia__) || \
defined(__NetBSD__) defined(__linux__) || defined(__NetBSD__)
#if _LIBUNWIND_SUPPORT_DWARF_UNWIND && _LIBUNWIND_SUPPORT_DWARF_INDEX #if _LIBUNWIND_SUPPORT_DWARF_UNWIND && _LIBUNWIND_SUPPORT_DWARF_INDEX
#include <link.h> #include <link.h>
// Macro for machine-independent access to the ELF program headers. This // Macro for machine-independent access to the ELF program headers. This
// macro is not available on some systems (e.g., FreeBSD). On these // macro is not available on some systems (e.g., FreeBSD). On these
// systems the data structures are just called Elf_XXX. Define ElfW() // systems the data structures are just called Elf_XXX. Define ElfW()
// locally. // locally.
#if !defined(ElfW) #if !defined(ElfW)
#define ElfW(type) Elf_##type #define ElfW(type) Elf_##type
▲ Show 20 Lines • Show All 525 Lines • Show Last 20 Lines

libunwind/trunk/src/assembly.h

Show First 20 Lines • Show All 41 Lines • ▼ Show 20 Lines
#elif defined(__ELF__) #elif defined(__ELF__)
#if defined(__arm__) #if defined(__arm__)
#define SYMBOL_IS_FUNC(name) .type name,%function #define SYMBOL_IS_FUNC(name) .type name,%function
#else #else
#define SYMBOL_IS_FUNC(name) .type name,@function #define SYMBOL_IS_FUNC(name) .type name,@function
#endif #endif
#if defined(__GNU__) || defined(__ANDROID__) || defined(__FreeBSD__) #if defined(__GNU__) || defined(__ANDROID__) || defined(__FreeBSD__) || \
defined(__Fuchsia__)
#define NO_EXEC_STACK_DIRECTIVE .section .note.GNU-stack,"",%progbits #define NO_EXEC_STACK_DIRECTIVE .section .note.GNU-stack,"",%progbits
#else #else
#define NO_EXEC_STACK_DIRECTIVE #define NO_EXEC_STACK_DIRECTIVE
#endif #endif
#else #else
#define SYMBOL_IS_FUNC(name) \ #define SYMBOL_IS_FUNC(name) \
Show All 37 Lines