Use uint32_t for alignment to match changes introduced in https://reviews.llvm.org/D25620
Details
Diff Detail
Event Timeline
include/clang/AST/ASTContext.h | ||
---|---|---|
83 ↗ | (On Diff #74685) | I'm not sure we want to use a debug info type inside the AST. I think we only want to use them in CGDebugInfo.cpp. |
include/clang/AST/ASTContext.h | ||
---|---|---|
83 ↗ | (On Diff #74685) | We use TypeInfo and related functions heavily in CGDebugInfo.cpp, leaving this field as "unsigned" will make us to perform conversions from "unsigned" to llvm::DIAlignment, I think having this changed will result in simpler code. |
include/clang/AST/ASTContext.h | ||
---|---|---|
83 ↗ | (On Diff #74685) | @dblaikie wrote:
We are discussing the possibility of changing this to "unsigned" in https://reviews.llvm.org/D25620, after we come to consensus I'll update both patches. Thanks for the advice, I agree that using DebugInfo types in AST was a bad idea. |
- Use uint32_t directly for alignment instead of creating typedef ofr it
- Get rid of DebugInfo dependency in AST
This patch is conflating two set of changes:
(1) NFC: rename all occurrences of unsigned for alignment purposes in the frontend with uint32_t
(2) shrink all debug-info-related alignment variables from uint64_t -> unint32_t.
I think this patch should only be doing the changes in (2).
- Removed all changes non-related to CGDebugInfo: will post them in separate NFC patch which will switch all unsigned alignment entries to uint32_t.
Agreed. Update this one. The (1) will come as separate NFC review along with corresponding LLVM patch.