Instead of keeping track of TODOs for lit in a file checked into source
control, use LLVM's bug tracker. The TODOs have been migrated to the
following bugs:
Details
Diff Detail
- Build Status
Buildable 386 Build 386: arc lint + arc unit
Event Timeline
@modocache Sorry for the delay in taking a look at this.
This change mostly LGTM except it looks like you've dropped these TODOs
* Move temp directory name into local test config. * Support valgrind in all configs, and LLVM style valgrind. * Support ulimit. * Create an explicit test suite object (instead of using the top-level TestingConfig object).
Is that intentional?
- "Move temp directory name into local test config" has been moved to https://llvm.org/bugs/show_bug.cgi?id=30673. Based on the comment on that bug, it may already be done!
- "Support ulimit" has been moved to https://llvm.org/bugs/show_bug.cgi?id=30672.
As for the others:
- I chose not to migrate "Create an explicit test suite object (instead of using the top-level TestingConfig object)" because I wasn't sure it was still relevant. It also seems like an implementation detail to me.
- I'd appreciate it if you could create a problem report for "Support valgrind in all configs, and LLVM style valgrind", @delcypher! I'm not sure I understand what is and isn't supported.
I'd appreciate it if you could create a problem report for "Support valgrind in all configs, and LLVM style valgrind", @delcypher! I'm not sure I understand what is and isn't supported.
I'm not entirely sure what this is either. lit can run tools under valgrind but I'm not sure if valgrind is actively used much these days for LLVM development. There are valgrind suppression files in the LLVM source tree (utils/valgrind) but they haven't been touched in a while but I'm guessing that's what this TODO was referring to. Really the idea of running the tests with a supervising tool needs to be generalized so arbitary stuff can be plugged in. For example it might be useful to have the system debugger attached to every process spawned so if one of them crashes it's easy to see what happened.
I could create a problem report for that if you like.
Also sorry for my slowness in replying :(
Thanks @delcypher! No worries about any lateness, I really appreciate the review!
A problem report for Valgrind would be appreciated, even if it's just "figure out what that old TODO was referring to." :)