This adds AVRISelLowering.cpp
Details
Details
Diff Detail
Diff Detail
Event Timeline
| llvm/trunk/lib/Target/AVR/AVRISelLowering.cpp | ||
|---|---|---|
| 97–98 ↗ | (On Diff #72968) | Setting these to Expand should be unnecessary since you don't add i32/i64 as legal types (same for all of the other operations) |
| 100 ↗ | (On Diff #72968) | Capitalize |
| 844–846 ↗ | (On Diff #72968) | Don't repeat the documentation |
| 849 ↗ | (On Diff #72968) | Comment doesn't make sense to me here |
| 1134 ↗ | (On Diff #72968) | nullptr |
| 1136–1140 ↗ | (On Diff #72968) | Why not just immediately cast to Function and then remove GV variable |
| 1321–1326 ↗ | (On Diff #72968) | Formatting |
| 1509 ↗ | (On Diff #72968) | static, no inline |
| 1674 ↗ | (On Diff #72968) | !CallOperandVal |
| 1782–1783 ↗ | (On Diff #72968) | You should be able to avoid a cast with getSubtarget<AVRSubtarget> |
Comment Actions
Code review from Matt
- Don't both setting operations to expand on already illegal types
- Clean up some comments
- Use nullptr rather than 0
| llvm/trunk/lib/Target/AVR/AVRISelLowering.cpp | ||
|---|---|---|
| 1136–1140 ↗ | (On Diff #72968) | We need the GV variable in the call to getTargetGlobalAddress |
| 1782–1783 ↗ | (On Diff #72968) | We don't have access to a Function object needed to call that functions. |
Else after return, same below.